Support orUpdate for SQLite #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kononnable
reviewed
May 7, 2019
pleerock
reviewed
May 9, 2019
| @@ -249,7 +249,7 @@ export class InsertQueryBuilder<Entity> extends QueryBuilder<Entity> { | |||
| if (statement && statement.overwrite instanceof Array) { | |||
| if (this.connection.driver instanceof MysqlDriver) { | |||
| this.expressionMap.onUpdate.overwrite = statement.overwrite.map(column => `${column} = VALUES(${column})`).join(", "); | |||
| } else if (this.connection.driver instanceof PostgresDriver) { | |||
| } else if (this.connection.driver instanceof PostgresDriver || this.connection.driver instanceof AbstractSqliteDriver) { | |||
| this.expressionMap.onUpdate.overwrite = statement.overwrite.map(column => `${column} = EXCLUDED.${column}`).join(", "); | |||
There was a problem hiding this comment.
hm so confusing, is it onUpdate or orUpdate? Looks like second, not sure who named it onUpdate before then.
There was a problem hiding this comment.
I could take advantage of this PR and change the key within expressionMap to orUpdate if you see it ok.
There was a problem hiding this comment.
we can left it as it is right now, and change it later (do it if you want), I just commented on what confused me...
|
@pleerock I want to mean SQLite doesn't seem to support Typeorm's |
|
I'm not sure if the error in CI is related with this PR (the last commit was only to solve the conflict in the Changelog file). Error message |
|
@emibloque its not your fault sometimes it hangs. |
|
Looks like okay to merge it @Kononnable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumary
This PR adds support of
QueryBuilder'sorUpdatefor SQLite.Issue
This closes issue #4096
Background
In PR #3056, support for
ON CONFLICTwas added for MySQL and Postgres when usingorUpdate, and in this PR #3190 support for PostgresonConflictwas added for SQLite as they have the same syntax.