Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sql.js v1.0 #4104

Closed
michaelbromley opened this issue May 8, 2019 · 0 comments · Fixed by #4105
Closed

Support sql.js v1.0 #4104

michaelbromley opened this issue May 8, 2019 · 0 comments · Fixed by #4105

Comments

@michaelbromley
Copy link
Contributor

Issue type:

[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[x] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Sql.js recently released v1.0, now compiled to WebAssembly. It has a new API for creating a connection, see docs on upgrading

Supporting the new API should only involve a rather minor change to SqljsDriver.createDatabaseConnectionWithImport() which I will attempt in a PR to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant