Support for SYSDATE in oracle Date column

[rjmohammad]

Issue type:

[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ x] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x ] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

Can't use SYSDATE in date column fields for Oracle because of this line
https://github.com/typeorm/typeorm/blob/master/src/driver/oracle/OracleDriver.ts#L364
the logic tries to parse the string or function being passed down.

Sample Oracle Query

INSERT INTO SOME_TABLE (Last_Upd_By, Last_Upd_Date)

VALUES ( P_Last_Upd_By, SYSDATE);

Sample Code:
Entity:

@Column('date', {
    nullable: true,
    name: 'CANCEL_REQ_DATE'
  })
  CANCEL_REQ_DATE: Date | null;

  @Column('date', {
    nullable: true,
    name: 'PLAN_END_DATE'
  })
  PLAN_END_DATE: Date | null;

@Column('varchar2', {
    nullable: true,
    length: 20,
    name: 'LAST_UPD_BY'
  })
  LAST_UPD_BY: string | null;

insertion:

    LAST_UPD_BY: lastUpdatedBy,
    CANCEL_REQ_DATE: 'SYSDATE', // for issue sample
    LAST_UPD_DATE: () => 'SYSDATE', // for issue sample
  });

Both SYSDATE format gives error.

Possible solutions may include adding a conditional on line #360

if (typeof value === 'function') {
  return value
}

Above proposed solution will give alot of flexibility to the users to run their desired queries/SQL functions if they don't want the default behavior.

The current workaround on my end includes creating a patch file that patches that piece of code at the time of my docker container creation.

I can make a PR if we are fine with my proposed solution.

Thanks!
RJ