selectQueryBuilder.take messes up the query when using the ids parameter

[cuchi]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[x] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[ ] latest
[ ] @next
[x] 0.2.20

Steps to reproduce or a small repository showing the problem:

This issue happens when I have something like:

const query = this.createQueryBuilder('employee')
// ... complex joins and stuff...
query.where('task.id IN (:...ids)', { ids: [foo, bar, etc] })

const result = await query.take(5).getMany()

This causes TypeORM to bahave unexpectedly, loading an empty result.

I can see in the generated query that it substitutes by :...ids with the parameters .take() uses internally.

I consider it a bug because it can frustrate a lot of unsuspecting people. Maybe I would rename it to something more obscure to the end user.