Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a prefix on SelectQueryBuilder internal parameters #5178

Merged
merged 6 commits into from
Dec 20, 2019

Conversation

cuchi
Copy link
Contributor

@cuchi cuchi commented Dec 4, 2019

Fixes #5174

@pleerock
Copy link
Member

pleerock commented Dec 5, 2019

If I remember it right oracle driver allows parameters only to start from a-z. So, I recommend to bring instead some non trivial name instead of using _ sign.

@cuchi cuchi changed the title Use a leading underscore on SelectQueryBuilder internal parameters Use a prefix on SelectQueryBuilder internal parameters Dec 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #5178 into master will decrease coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
- Coverage   76.84%   76.25%   -0.59%     
==========================================
  Files         266      266              
  Lines       19124    19125       +1     
  Branches     5014     5014              
==========================================
- Hits        14695    14583     -112     
- Misses       4429     4542     +113
Impacted Files Coverage Δ
src/query-builder/SelectQueryBuilder.ts 89.52% <100%> (+0.01%) ⬆️
src/error/NoConnectionOptionError.ts 33.33% <0%> (-50.01%) ⬇️
src/error/ConnectionIsNotSetError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/NoConnectionForRepositoryError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/DriverOptionNotSetError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/TreeRepositoryNotSupportedError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/SubjectWithoutIdentifierError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/DriverPackageNotInstalledError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/ColumnTypeUndefinedError.ts 28.57% <0%> (-42.86%) ⬇️
src/error/MissingPrimaryColumnError.ts 28.57% <0%> (-42.86%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb60688...4eecc98. Read the comment docs.

@cuchi cuchi changed the title Use a prefix on SelectQueryBuilder internal parameters fix: use a prefix on SelectQueryBuilder internal parameters Dec 9, 2019
@pleerock pleerock merged commit cacb08b into typeorm:master Dec 20, 2019
@pleerock
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selectQueryBuilder.take messes up the query when using the ids parameter
3 participants