Default enum null value causes a bug

[OrkhanAlikhanov]

Issue type:

[x] bug report

Database system/driver:

[x] mysql / mariadb

TypeORM version:

[x] latest
[x] @next

Steps to reproduce or a small repository showing the problem:
Create an enum column with default value null

enum MyEnum {
  valueA = 'valueA',
  valueB = 'valueB',
}

@Entity()
export class Entity extends BaseEntity {
  @Column({
    type: 'enum',
    enum: MyEnum,
    nullable: true,
    default: null,
  })
  field?: MyEnum;
}

result

{
  message: "Invalid default value for 'field'",
  code: 'ER_INVALID_DEFAULT',
  errno: 1067,
  sqlState: '42000',
  sqlMessage: "Invalid default value for 'field'",
  name: 'QueryFailedError',
  query: "ALTER TABLE `entity` CHANGE `field` `field` enum ('valueA', 'valueB') NULL DEFAULT 'null'",
  parameters: []
}

It should've generated query: "ALTER TABLE ``entity`` CHANGE ``field`` ``field`` enum ('valueA', 'valueB') NULL DEFAULT null",

Adding && defaultValue !== null seems to work

typeorm/src/driver/mysql/MysqlDriver.ts

Line 572 in e8eb98b

if ((columnMetadata.type === "enum" || columnMetadata.type === "simple-enum") && defaultValue !== undefined) {

[robertrypula]

Any updates on this topic? I'm stuck in the same issue :(

---

UPDATE after quick experiments:

changing 'null'

@Column('enum', { enum: StructuralNode, nullable: true, default: null})
public structuralNode: StructuralNode;

to 'undefined' seems to work in my case :)

@Column('enum', { enum: StructuralNode, nullable: true, default: undefined })
public structuralNode: StructuralNode;

[agoulziprod]

this solution found here: #4833 worked for me finally,

{
    name: 'status',
    type: 'enum',
    enum: ['active', 'inactive', 'paused'],
    enumName: 'statusEnum',
    default: '"inactive"'
}

[falahati]

This happens with PostgreSQL as well.
Following is the result of TypeOrm field definition:

"status" "status_enum" DEFAULT \'null\'

From:

@Column({ name: "status", type: "enum", enum: Status, nullable: true, default: null })
public status: Status| null = null;

Resulting in:

'invalid input value for enum status_enum: "null"'

Probably due to putting null inside '' and escaping it.

Suggested answer by @robertrypula just removes the default value since by setting the property to undefined we are telling TypeOrm that there is no default value for this field. This is not a workaround; it is just a way to ignore the bug.

[falahati]

The same fix when applied here should fix the problem with PostgreSQL:

https://github.com/typeorm/typeorm/blob/master/src/driver/postgres/PostgresDriver.ts#L724

[pleerock]

what is the point to set default: null, if when you set nullable: true database already sets you a null by default?

[nebkat]

It is probably unnecessary if the database uses null by default, but likely the user is just trying to be explicit with the default value and there shouldn't be unexpected behavior like this.