Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot read property 'hasMetadata' of undefined #5659

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix: Cannot read property 'hasMetadata' of undefined #5659

merged 2 commits into from
Oct 8, 2020

Conversation

haoyuhu
Copy link
Contributor

@haoyuhu haoyuhu commented Mar 11, 2020 •
edited
Loading

issue #3685

@azymnis
Copy link

azymnis commented Jul 10, 2020

We just hit this bug today again. Any chance this could be merged?

@imnotjames imnotjames self-requested a review October 8, 2020 06:08
imnotjames
imnotjames approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, all tests are passing, new tests added.

Looks good to me.

@imnotjames imnotjames merged commit 0280cdc into typeorm:master Oct 8, 2020
@imnotjames
Copy link
Contributor

Thanks for the contribution!

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 8, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@haoyuhu
fix: Cannot read property 'hasMetadata' of undefined (typeorm#5659)
b4e2e24 
fixes typeorm#3685
@AlexMesser AlexMesser mentioned this pull request Apr 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haoyuhu @azymnis @imnotjames