Fix query builder crashing when using object in .where inside Brackets #4337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This small functionality got too complex in my opinion. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
imnotjames
requested changes
Oct 18, 2020
| * Creates a query builder that shares some context with another query-builder. | ||
| * Used for creating Bracket Query Builders. | ||
| */ | ||
| createBracketsQueryBuilder(): this { |
| expressionMap.aliasNamePrefixingEnabled = this.expressionMap.aliasNamePrefixingEnabled; | ||
| expressionMap.nativeParameters = this.expressionMap.nativeParameters; | ||
|
|
||
| return new (this.constructor as any)(this.connection, this.queryRunner, expressionMap); |
There was a problem hiding this comment.
I'm guessing that creating a new query builder by passing this query builder into it does not fix the issue? That would clone the expression map. eg use clone instead of this function
| beforeEach(() => reloadTestingDatabases(connections)); | ||
| after(() => connections && closeTestingConnections(connections)); | ||
|
|
||
| it("should accept objects in .where method (github issue #3685)", () => Promise.all(connections.map(async connection => { |
There was a problem hiding this comment.
You don't need to reference the issue in it but should explain what it should and should not do.
|
|
||
| it("should accept objects in .where method (github issue #3685)", () => Promise.all(connections.map(async connection => { | ||
|
|
||
| await Promise.all([ |
There was a problem hiding this comment.
const repo = connection.getRepository(User);
await Promise.all([repo.save({ first name: "Jean", last name:"Doe"})])
|
Superseded by #5659. Anyway, thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #3685 where the following piece of code
would crash because the QueryBuilder could not determine the alias to use for
id