You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All three config options above produce the same result, which is an ioredis query cache connected to myhost on port 1234, database index 1
Actual Behavior
Option 1 succeeds.
Option 2 ignores port and only uses the values inside the options block, using the ioredis default port 6379. Connection fails.
Option 3 ignores port and attempts to connect to localhost:6379, and fails.
Steps to Reproduce
Try each of the listed cache configs in your ormconfig.js
My Environment
Dependency
Version
Operating System
Node.js version
v14.16.1
Typescript version
v3.9.9
TypeORM version
v0.2.32
ioredis version
v4.27.2
Additional Context
Relevant Database Driver(s)
aurora-data-api
aurora-data-api-pg
better-sqlite3
cockroachdb
cordova
expo
ioredis
mongodb
mysql
nativescript
oracle
postgres
react-native
sap
sqlite
sqlite-abstract
sqljs
sqlserver
Are you willing to resolve this issue by submitting a Pull Request?
I've made a fix & tested locally. Just need guidance with the pull request.
Yes, I have the time, and I know how to start.
Yes, I have the time, but I don't know how to start. I would need guidance.
No, I don't have the time, although I believe I could do it if I had the time...
No, I don't have the time and I wouldn't even know how to start.
The text was updated successfully, but these errors were encountered:
According to the ioredis documentation, a URL may be passed in the 'port' parameter.
This does not currently work when using an ioredis cache. Modify ioredis connection logic
to conform to ioredis standards.
Closes: #7631
Co-authored-by: Joe Caputo <joseph.caputo@atomyze.us>
Issue Description
According to the ioredis docs, the following connection options are equivalent within the
cache {}
block:Expected Behavior
All three config options above produce the same result, which is an ioredis query cache connected to
myhost
on port1234
, database index1
Actual Behavior
Option 1 succeeds.
Option 2 ignores
port
and only uses the values inside theoptions
block, using the ioredis default port 6379. Connection fails.Option 3 ignores
port
and attempts to connect tolocalhost:6379
, and fails.Steps to Reproduce
Try each of the listed cache configs in your
ormconfig.js
My Environment
Additional Context
Relevant Database Driver(s)
aurora-data-api
aurora-data-api-pg
better-sqlite3
cockroachdb
cordova
expo
ioredis
mongodb
mysql
nativescript
oracle
postgres
react-native
sap
sqlite
sqlite-abstract
sqljs
sqlserver
Are you willing to resolve this issue by submitting a Pull Request?
I've made a fix & tested locally. Just need guidance with the pull request.
The text was updated successfully, but these errors were encountered: