Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bad query when using take on entity with multiple pk #1146

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

elthrasher
Copy link
Contributor

Both conditions and parameters were invalid. Try running my tests against the old code. These changes fix the problem - though I'm not sure if they match the original intent.

@pleerock pleerock merged commit 5d29844 into typeorm:master Nov 6, 2017
@pleerock
Copy link
Member

pleerock commented Nov 6, 2017

Looks proper, thank you for your contribution

@elthrasher elthrasher deleted the take-with-multiple-pk branch November 6, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants