Some fixes in MigrationCreateCommand #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to function; fixing order of methods
pleerock
reviewed
Jan 26, 2017
|
|
||
| export class ${name}${timestamp} implements MigrationInterface { | ||
|
|
||
| async up(queryRunner: QueryRunner, connection: Connection, entityManager?: EntityManager): Promise<any> { | ||
| public async up(queryRunner: QueryRunner, connection: Connection, entityManager?: EntityManager): Promise<any> { | ||
| ; |
There was a problem hiding this comment.
this is really disgusting tslint rule.
There was a problem hiding this comment.
We have not been setting this rule explicitly, it is part of the default rule set. In any case, would you still consider this pull request? Or do you need me to change anything?
There was a problem hiding this comment.
yes, of course we need to have EntityManager in imports. I'm okay with public keyword (however don't really like it). But having ; is not acceptable. Please change only this part.
|
Done. Removed semicolons in empty functions. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
despite adding the missing import for class "EntityManager", I propose some changes to meet some more strict tslint rules.
Please let me know if this will work for you.
Tobias.