Spatial support for PostgreSQL using PostGIS #2423

mojodna · 2018-06-28T14:00:40Z

This includes support for both geometry and geography columns as well as GiST indices (used when passing the spatial: true option). Client representations use GeoJSON (existing MySQL and MS SQL drivers use WKT (well-known text)) for compatibility with geospatial libraries such as Turf, JSTS, etc.

Fixes #370

This includes support for both geometry and geography columns as well as GiST indices (used when passing the `spatial: true`). Client representations use GeoJSON (existing MySQL and MS SQL drivers use WKT (well-known text)) for compatibility with geospatial libraries such as Turf, JSTS, etc.

mojodna · 2018-06-28T14:29:31Z

@AlexMesser

OKNoah · 2018-06-29T04:54:30Z

@mojodna Thanks, I was just about to do this! I'm going to try add a test or function for orderBy based on distance from a certain input.

Specifying a feature type will pass it as a parameter to the underlying spatial type, allowing PostGIS to validate that stored geometries match expectations. Specifying an SRID will do similarly, with the additional benefit of allowing the coordinate system used for a geometry to be stored in order to transform it into other coordinate systems.

This way, if transforms are applied to parameters, they only need to be implemented in 1 place.

mojodna · 2018-06-29T23:54:02Z

See mojodna#1 for more discussion on this.

This allows synchronization to modify PostGIS constraints while also surfacing metadata in expected places.

mojodna · 2018-07-02T05:20:36Z

test/functional/query-builder/order-by/entity/Post.ts

+    @Column({ type: "geometry" })
+    @Index({ spatial: true })


This looks like it broke the build; some of the before/after hooks are now hanging. Is there a good way to diagnose this?

Ah, it looks like introducing support for spatial indexes in Postgres is conflicts with tests that also execute in MySQL. I think I've just pushed a fix for this.

Since the order-by tests run for multiple database engines, including Postgres-targeted spatial types will break other engines (or cause them to hang on startup).

pleerock · 2018-07-02T18:42:18Z

src/driver/postgres/PostgresDriver.ts

@@ -370,7 +384,7 @@ export class PostgresDriver implements Driver {
            || columnMetadata.type === "timestamp without time zone") {
            return DateUtils.mixedDateToDate(value);

-        } else if (columnMetadata.type === "json" || columnMetadata.type === "jsonb") {
+        } else if (this.spatialTypes.concat(["json", "jsonb"]).indexOf(columnMetadata.type) >= 0) {


previous one was better =)

waits for Array.includes in TS...

Local style should be:

} else if (columnMetadata.type === "json" || columnMetadata.type === "jsonb" || this.spatialTypes.indexOf(columnMetadata.type) >= 0) {

❓

no, thats fine as well, you can keep it. I simply don't like concat, I would either go with "local style" you wrote or ["json", "jsob", ... this.spatialTypes].indexOf() which looks much better than concat

Ah, right, I always forget about spreads in this context.

pleerock · 2018-07-02T18:43:53Z

docker-compose.yml

@@ -39,7 +39,7 @@ services:

  # postgres
  postgres:
-    image: "postgres:9.6.1"
+    image: "mdillon/postgis:9.6"


I guess somebody else can easily create a PR for the feature with specific extension and put another docker image with that extension, but without gis let's say. So better solution would be to have a base postgres image with all modifications applied

Agreed. mdillon/postgis is just postgres + PostGIS (pretty sure it doesn't include any other additional extensions). Is this worth punting on until someone else needs to add another extension? (We can add a note/apology here ;-)

haha yeah... I hope it won't be me 😆

pleerock · 2018-07-02T18:48:11Z

wow, this is huge. This wasn't an easy thing to implement, how much time it took you to bring all this into TypeORM?)

Lets ask @AlexMesser if he can review it.

mojodna · 2018-07-02T19:01:33Z

Thanks! I'm guessing ~8 hours (including getting familiar with TypeORM generally while on a plane) over the span of a week and a half..

pleerock · 2018-07-02T19:05:29Z

You are the beast!

AlexMesser · 2018-07-03T12:24:17Z

Great work!
Also, please create documentation for SpatialColumnOptions and its usage.

mojodna · 2018-07-03T17:35:49Z

@AlexMesser docs pushed.

pleerock · 2018-07-03T18:04:16Z

Thank you very much! This will be published in 0.2.8 soon!

RDeluxe · 2018-07-03T23:13:19Z

Awesome work @mojodna , thanks again !

htonkovac · 2018-07-12T16:20:20Z

When can we expect 0.2.8 to be released?

sublimator · 2018-08-04T04:11:50Z

Yes please to 0.2.8!

pleerock · 2018-08-04T07:22:10Z

we have a blocking issue with nativescript that is merged and prevent block releasing 0.2.8

lorenzopicoli · 2018-08-30T20:45:06Z

Any update on the 0.2.8 release @pleerock?

lucashsilva · 2018-09-06T02:33:07Z

Looking forward for this

Vincz · 2018-10-05T04:38:02Z

Hi @pleerock , Any update about the next release ?

hussainwali74 · 2021-05-09T20:17:03Z

I just want a simple example please:
how to insert lat-long point dataa into postgres, find distance between 2 points??

I have this column:

@Index({ spatial: true })
 @Column({
   type: 'geometry',
   srid: 4326,
   nullable: true,
   spatialFeatureType: 'Point',
   transformer: {
     to: (v: Point) => {
       console.log(v);
       console.log(JSON.stringify(v));
       return eval(
         `ST_GeomFromGeoJSON('{"type":"Point","coordinates":[39.807222,-76.984722]}')`,
       );
     },
     from: (v: any) => {
       return v;
     },
   },
 })
 current_location: string;

when I try to insert data:
"current_location": "{"type":"Point","coordinates":[39.807222,-76.984722]}",

it says ST_GeomFromGeoJSON is not defined. Please help

mojodna · 2021-05-10T00:35:00Z

It looks like you don’t have the PostGIS extension installed. To enable it in a specific database, run create extension postgis directly from psql.

hussainwali74 · 2021-05-10T10:03:16Z

It looks like you don’t have the PostGIS extension installed. To enable it in a specific database, run create extension postgis directly from psql.

@mojodna sir,
I already have postgis installed, ST_GeomFromGeoJSON works in the psql cli
also here is the screenshot of SELECT postgis_full_version();

I am also able to run all these from within my nodejs code. (all the commented queries also work fine)

  async test() {
    // const query = `SELECT * FROM v`
    const query = `select St_AsGeoJson(current_location) from vehicle where vehicle_id=4;    `;
    // works => select ST_Distance(ST_GeometryFromText('POINT(0 0)',4326),current_location) from vehicle where vehicle_id=4;
    // SELECT ST_GeomFromGeoJSON('{"type":"Point","coordinates":[39.807222,-76.984722]}');
    // select ST_Distance(ST_GeometryFromText('POINT(32.333 1.233)',0), current_location::geometry) from vehicle;
    // select ST_Distance(ST_GeometryFromText('POINT(32.333 1.233)',4326),ST_GeometryFromtext('POINT(42.322 1.234)',4326));
    // const query = `SELECT ST_Distance (ST_GeomFromText('POINT(0 0'), ST_X(current_location))
    // FROM vehicle
    // GROUP BY type`;

    // INSERT INTO vehicle(base_location,current_location) VALUES
    // ( 'Islamabad',ST_GeomFromGeoJSON('{"type":"Point","coordinates":[28.612849, 77.229883]}'));
    try {
      return await this.vehicleRepository.query(query);
    } catch (error) {
      throw new HttpException(error, HttpStatus.NOT_IMPLEMENTED);
    }
  }

Only issue is when I try to insert data using typeorm, it gives me the error ST_GeoomFromText() is not a function

mojodna force-pushed the postgis branch from 27c6796 to b371c06 Compare June 29, 2018 16:33

mojodna added 3 commits June 29, 2018 11:43

Add missing interface

a266a5a

Use this.setParameter() internally

c51dfcc

This way, if transforms are applied to parameters, they only need to be implemented in 1 place.

Demonstrate parameter-bound WHERE and ORDER BY

cfbea13

mojodna added 4 commits July 1, 2018 13:24

Use functions when updating spatial columns

84e9386

Correctly populate feature type + SRID constraints

0d8b343

Load SRID + feature type from the db

ce94295

This allows synchronization to modify PostGIS constraints while also surfacing metadata in expected places.

Detect spatial feature type + SRID changes

430b8cd

mojodna commented Jul 2, 2018

View reviewed changes

Remove unused geometry column

f935457

Since the order-by tests run for multiple database engines, including Postgres-targeted spatial types will break other engines (or cause them to hang on startup).

pleerock reviewed Jul 2, 2018

View reviewed changes

Merge branch 'master' into postgis

bcae80f

mojodna added 2 commits July 2, 2018 12:06

Improve readability

61f64d2

Explanation of / apology for mdillon/postgis

7893c66

mojodna mentioned this pull request Jul 2, 2018

How to create geometry with SRID reference #2443

Closed

mojodna added 3 commits July 3, 2018 09:59

Document spatial indices

4a5c7ec

Add missing semicolon

c8b87c8

Doc spatial columns

e1f6aa4

adding missing links

53e2b36

adding missing links

2e069ce

pleerock merged commit eece0c3 into typeorm:master Jul 3, 2018

AlexMesser mentioned this pull request Mar 20, 2019

Synchronize option triggers errors with Postgres extensions tables #1552

Closed

xxRockOnxx mentioned this pull request Apr 7, 2019

Entity schemas documentation #2001

Closed

vlapo mentioned this pull request May 27, 2019

Postgres ltree extension #4193

Closed

This was referenced Jul 29, 2023

Modify driver.supportedDataTypes to support installed Postgres extension data type. Bypass validation for a column. #10056

Open

feat: Add vector as column type to postgres #10138

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spatial support for PostgreSQL using PostGIS #2423

Spatial support for PostgreSQL using PostGIS #2423

mojodna commented Jun 28, 2018 •

edited

mojodna commented Jun 28, 2018

OKNoah commented Jun 29, 2018

mojodna commented Jun 29, 2018

mojodna Jul 2, 2018

mojodna Jul 2, 2018

pleerock Jul 2, 2018

mojodna Jul 2, 2018

pleerock Jul 2, 2018 •

edited

mojodna Jul 2, 2018

pleerock Jul 2, 2018

mojodna Jul 2, 2018 •

edited

pleerock Jul 2, 2018 •

edited

pleerock commented Jul 2, 2018

mojodna commented Jul 2, 2018

pleerock commented Jul 2, 2018

AlexMesser commented Jul 3, 2018

mojodna commented Jul 3, 2018

pleerock commented Jul 3, 2018

RDeluxe commented Jul 3, 2018

htonkovac commented Jul 12, 2018

sublimator commented Aug 4, 2018

pleerock commented Aug 4, 2018

lorenzopicoli commented Aug 30, 2018

lucashsilva commented Sep 6, 2018

Vincz commented Oct 5, 2018

hussainwali74 commented May 9, 2021

mojodna commented May 10, 2021

hussainwali74 commented May 10, 2021 •

edited

Spatial support for PostgreSQL using PostGIS #2423

Spatial support for PostgreSQL using PostGIS #2423

Conversation

mojodna commented Jun 28, 2018 • edited

mojodna commented Jun 28, 2018

OKNoah commented Jun 29, 2018

mojodna commented Jun 29, 2018

mojodna Jul 2, 2018

Choose a reason for hiding this comment

mojodna Jul 2, 2018

Choose a reason for hiding this comment

pleerock Jul 2, 2018

Choose a reason for hiding this comment

mojodna Jul 2, 2018

Choose a reason for hiding this comment

pleerock Jul 2, 2018 • edited

Choose a reason for hiding this comment

mojodna Jul 2, 2018

Choose a reason for hiding this comment

pleerock Jul 2, 2018

Choose a reason for hiding this comment

mojodna Jul 2, 2018 • edited

Choose a reason for hiding this comment

pleerock Jul 2, 2018 • edited

Choose a reason for hiding this comment

pleerock commented Jul 2, 2018

mojodna commented Jul 2, 2018

pleerock commented Jul 2, 2018

AlexMesser commented Jul 3, 2018

mojodna commented Jul 3, 2018

pleerock commented Jul 3, 2018

RDeluxe commented Jul 3, 2018

htonkovac commented Jul 12, 2018

sublimator commented Aug 4, 2018

pleerock commented Aug 4, 2018

lorenzopicoli commented Aug 30, 2018

lucashsilva commented Sep 6, 2018

Vincz commented Oct 5, 2018

hussainwali74 commented May 9, 2021

mojodna commented May 10, 2021

hussainwali74 commented May 10, 2021 • edited

mojodna commented Jun 28, 2018 •

edited

pleerock Jul 2, 2018 •

edited

mojodna Jul 2, 2018 •

edited

pleerock Jul 2, 2018 •

edited

hussainwali74 commented May 10, 2021 •

edited