feat: added support for IORedis in TypeORM caching #3289
Conversation
|
@pleerock @Kononnable , this PR is against the master branch. I have also refactored the code a bit so that there is no duplication. almost all the methods were reused except for the connect method which i have handled. Do let me know if this works for you guys or not. |
src/cache/RedisQueryResultCache.ts
Outdated
| this.client = this.redis.createClient(); | ||
| } | ||
| } else if (this.clientType === "ioredis") { | ||
| if (cacheOptions && cacheOptions.options) {this.client = this.redis.createClient(); |
There was a problem hiding this comment.
is it typo? this.client is being assigned two times?
There was a problem hiding this comment.
indeed it was. i have fixed it.
|
@pleerock , if you are going ahead with the merge, should i update the caching documentation as well? |
|
yes, please :) |
src/cache/RedisQueryResultCache.ts
Outdated
| /** | ||
| * Type of the Redis Client (redis or ioredis). | ||
| */ | ||
| protected clientType: string; |
There was a problem hiding this comment.
type can be set to "redis" | "ioredis" - that way we can omit a comment which can become outdated in the future
There was a problem hiding this comment.
I have updated the type to protected clientType: "redis" | "ioredis";. However, i have still kept the comment to make it consistent with other protected properties. I thought that if in the future, the type was changed, the comment could be changed with it as well.
Let me know if the comment still needs to be removed.
…g to redis | ioredis
|
@pleerock documentation updated. |
|
Hey guys, how are you? Now that i've read the documentation update, and the options. I'm thinking that this new implementation does not support the Cluster options for ioredis is that correct? https://github.com/luin/ioredis/blob/master/API.md#Cluster if thats the case, do you have any plans on implementing this? If not, may I take a look into supporting such feature? Thanks! |
|
Hey guys, any news on this? |
|
Think we can merge it, thanks for the contribution! |
No description provided.