fix(query builder): Throw error on missing or unknown properties #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vlapo
commented
Dec 25, 2018
vlapo
commented
- handle emptiness and wrong properties in update query builder
- fix Query builder update generates broken SQL #2849
pleerock
reviewed
Dec 25, 2018
pleerock
reviewed
Dec 25, 2018
| constructor() { | ||
| super(); | ||
| Object.setPrototypeOf(this, UpdateValuesMissingError.prototype); | ||
| this.message = `Cannot perform update query because update values are not defined. Call "qb.set(...)" method to specify inserted values.`; |
pleerock
reviewed
Dec 25, 2018
src/error/ColumnMetadataNotFound.ts
Outdated
| constructor(propertyPath: string) { | ||
| super(); | ||
| Object.setPrototypeOf(this, ColumnMetadataNotFoundError.prototype); | ||
| this.message = `No column metadata for property "${propertyPath}" was found.`; |
There was a problem hiding this comment.
probably we need to give more user-friendly error. Users don't know what "metadata" means.
There was a problem hiding this comment.
You are right. We need more user friendly errors. What do you suggest?
EntityColumnNotFound -> No entity column "${propertyPath}" was found.?
|
Totally forgot. Updated by comments. |
|
Thank you. This is important to mention in changelog. In can break some exist code in a way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.