Fix DriverUtils.buildDriverOptions #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marines
reviewed
Jan 17, 2019
marines
reviewed
Jan 17, 2019
src/driver/DriverUtils.ts
Outdated
| }; | ||
| return Object.assign(urlDriverOptions, options); | ||
| } | ||
| urlDriverOptions.sid = parsedUrl.database |
There was a problem hiding this comment.
Suggested change
| urlDriverOptions.sid = parsedUrl.database | |
| urlDriverOptions.sid = parsedUrl.database; |
marines
reviewed
Jan 17, 2019
…YPEORM_URL originated parameters
|
Thank you. Would be great to have a test coverage for this functionality to prevent issues in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DriverUtils.buildDriverOptions static method to actually assign TYPEORM_URL originated parameters. There has been couple of past PR's for this, so now it's better to make it simpler with only one way to get the parameters.
The new logic assigns parameters by default from the options values, and secondly from parsed TYPEORM_URL originated parameters. Finally the parsed parameters are assigned on top of options.