Connection.dropDatabase() leaks an unreleased db client #3727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryRunner in Connection.dropDatabase() must be released similarly to Connection.query() method.
I had a situation where no more queries could be done because I had 10 clients leaked in the query pool.
In my case dropDatabase() method failed because of a deadlock in postgres, this caused no release() to be called. Postgres Pool has a default of max 10 connections. When all 10 connections were failed dropDatabase calls (not released), no more queries could be performed and hanged forever.