Extend afterLoad() subscriber interface to take LoadEvent #4186
+138
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't get a clean full test run on my laptop, but most tests passed and I didn't see any regressions with the proposed code change. |
This brings it in line with the other events which already have the Connection, EntityManager, QueryRunner etc available. Test Plan: npm test, and more specifically npm test -- --grep='github issues > #4185'
|
Looks good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it in line with the other events which already have the Connection, EntityManager, QueryRunner etc available.
Test Plan: npm test, and more specifically npm test -- --grep='github issues > #4185'