Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 4691 #4694

Merged
merged 1 commit into from
Sep 5, 2019
Merged

fixed issue 4691 #4694

merged 1 commit into from
Sep 5, 2019

Conversation

CavidM
Copy link
Contributor

@CavidM CavidM commented Sep 5, 2019

@pleerock
Copy link
Member

pleerock commented Sep 5, 2019

Don't think it's a right approach but we can merge it for now. This would definitely fail again if we do not attach tests for this issue.

@cajames
Copy link

cajames commented Sep 16, 2019

@CavidM @pleerock This seems to cause an error for connection configs with replication. Please note the lack of the database property on the root object.

Example config:

{
  type: "mysql",
  replication: {
    master: {
      host: "DB_HOST",
      port: "DB_PORT",
      username: "DB_USER",
      password: "DB_PASSWORD",
      database: "DB_NAME"
    },
    slaves: [
      {
        host: "RO_DB_HOST",
        port: "DB_PORT",
        username: "DB_USER",
        password: "DB_PASSWORD",
        database: "DB_NAME"
      }
    ]
  },
  entities: [...]
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants