Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrations run in reverse order for mongodb #4702

Conversation

RecuencoJones
Copy link
Contributor

@RecuencoJones RecuencoJones commented Sep 6, 2019

  • update loadExecutedMigrations to get migrations sorted by id from database
  • add missing await statements when running mongodb migrations

Fixes #4697

@RecuencoJones
Copy link
Contributor Author

Looks like this test is a bit inconsistent, any better ways to check which migrations were run?

@RecuencoJones RecuencoJones force-pushed the fix-4679-running-migrations-in-right-order-for-mongodb branch 2 times, most recently from 0e40cfb to 618b9c6 Compare September 9, 2019 08:14
* update `loadExecutedMigrations` to get migrations sorted by id from database
* add missing await statements when running mongodb migrations
@RecuencoJones RecuencoJones force-pushed the fix-4679-running-migrations-in-right-order-for-mongodb branch from 618b9c6 to 2837ad1 Compare September 12, 2019 13:11
@pleerock pleerock merged commit 2f27581 into typeorm:master Oct 18, 2019
@RecuencoJones RecuencoJones deleted the fix-4679-running-migrations-in-right-order-for-mongodb branch October 18, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert migrations running in reverse order
3 participants