Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to Column to specify the complete enumName #4824

Merged
merged 1 commit into from Oct 18, 2019
Merged

Add option to Column to specify the complete enumName #4824

merged 1 commit into from Oct 18, 2019

Conversation

ejose19
Copy link
Contributor

@ejose19 ejose19 commented Sep 27, 2019

This fixes #4106 and #4741

@ejose19
Copy link
Contributor Author

ejose19 commented Sep 28, 2019

@pleerock @vlapo

Copy link
Contributor

@elmpp elmpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks extremely good to moi

@pleerock
Copy link
Member

Okay, looks like many likes for this feature

@pleerock pleerock merged commit d967180 into typeorm:master Oct 18, 2019
@elmpp
Copy link
Contributor

elmpp commented Oct 23, 2019

thank you @ejose19 @pleerock

@elmpp
Copy link
Contributor

elmpp commented Oct 23, 2019

@ejose19 - am i'm right in thinking this won't affect the migrations generated? It appears they're still being prefixed with table names and ignoring the new enumName..

I can take a crack at a PR if i can get a few pointers..

@ejose19
Copy link
Contributor Author

ejose19 commented Oct 23, 2019

@elmpp Yes, I didn't work on any migration related file so I assume they're not affected. I suggest you to use "find file" button on the root of this project, search for "migration" and start your way from there. Also maybe @pleerock can give you some insight

@pleerock
Copy link
Member

Solution is to research how current approach works and refactor it considering these changes.

jorenvandeweyer added a commit to jorenvandeweyer/typeorm that referenced this pull request Apr 15, 2021
AlexMesser pushed a commit that referenced this pull request Apr 17, 2021
Added minor documentation for #4824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify enum type name in postgres
3 participants