Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: migrate from slave/master terms to primary/replica #6324

Closed

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jun 28, 2020

this change updates terminology to "primary"/"replica"

more inclusive terminology can lead to a more inclusive project

the terminology master/slave is considered non-inclusive by many
and most databases that this project uses are also migrating away
from the terminology.

this leaves the original "master" and "slave" terminology in place
but marks them as deprecated & points them at the primary/replica
terminology. at the next breaking change branch these can be removed
with a warning about the breaking change in the changelog

@imnotjames imnotjames force-pushed the chore/primary-replica-naming branch from 7da4b4d to db69a43 Compare June 28, 2020 03:05
@imnotjames imnotjames changed the title migrate from slave/master terms to primary/replica style: migrate from slave/master terms to primary/replica Jun 28, 2020
@imnotjames imnotjames force-pushed the chore/primary-replica-naming branch from db69a43 to 61108ac Compare June 28, 2020 03:09
@imnotjames
Copy link
Contributor Author

imnotjames commented Jun 28, 2020

I did my best to ensure this wouldn't break existing code that may rely on the previous termonology.

However, if we wanted to make this into a breaking change that could be arranged. :)

@imnotjames imnotjames force-pushed the chore/primary-replica-naming branch from 61108ac to ccfff84 Compare June 28, 2020 07:05
this change updates terminology to "primary"/"replica"

more inclusive terminology can lead to a more inclusive project

the terminology master/slave is considered non-inclusive by many
and most databases that this project uses are also migrating away
from the terminology

this leaves the original "master" and "slave" terminology in place
but marks them as deprecated & points them at the primary/replica
terminology.  at the next breaking change branch these can be removed
with a warning about the breaking change in the changelog
@imnotjames imnotjames force-pushed the chore/primary-replica-naming branch from ccfff84 to f537cf5 Compare June 28, 2020 07:44
@pleerock
Copy link
Member

pleerock commented Jul 2, 2020

Unfortunately this is a breaking change, and we can't do it right now because it will break user code. But in the future versions, I'm sure we'll apply these changes.

@imnotjames
Copy link
Contributor Author

imnotjames commented Jul 2, 2020

This is a breaking change? What can we do to make it less of a breaking change?

I did what I could to ensure the changes wouldn't cause backwards compat breakages, thought it had worked per tests.

@imnotjames
Copy link
Contributor Author

Either way, though, thanks for looking at it! Looking forward to when this change can be made. Happy to help out with it against whatever branch is the next breaking release. :)

@imnotjames
Copy link
Contributor Author

imnotjames commented Jul 21, 2020

I'll close this for now so we don't clutter up the pull requests with things that aren't gonna be merged in right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants