Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: condition is optional in SelectQueryBuilder joins #7888

Merged
merged 2 commits into from
Jul 11, 2021
Merged

fix: condition is optional in SelectQueryBuilder joins #7888

merged 2 commits into from
Jul 11, 2021

Commits on Jul 11, 2021

  1. fix: condition is optional in SelectQueryBuilder joins 

    the condition seems to have been accidentally marked as required when
it's actually optional in the underlying implementation.  this marks
the condition in any join within `SelectQueryBuilder` as optional
    @imnotjames
    imnotjames committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    409bb27 View commit details
    Browse the repository at this point in the history

  2. fix missed definition

    @imnotjames
    imnotjames committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    d73c933 View commit details
    Browse the repository at this point in the history