perf: don't recompile escapeRegExp for every query #8956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: the query builder is pretty CPU intensive, and can be slow - e.g. typeorm#3857 One of the things which makes this slow is `escapeRegExp` in the query builder: we freshly construct the same RegExp once per `replacePropertyName` invocation (many times per overall query!) and since the RegExp itself is constant -- we can lift it out and construct it once. Over-all this saves about 8% on our query build times as measured by typeorm#8955.
draaglom
force-pushed
the
draaglom/perf-regex-escape
branch
from
6ad6040
to
c28383c
Compare
|
thank you for contribution! |
draaglom
added a commit
to draaglom/typeorm
that referenced
this pull request
May 23, 2022
Digging further into typeorm#3857. See also typeorm#8955, typeorm#8956. As [previously discussed](typeorm#3857 (comment)), the query builder currently suffers from poor performance in two ways: quadratic numbers of operations with respect to total table/column counts, and poor constant factor performance (regexps can be expensive to build/run!) The constant-factor performance is the more tractable problem: no longer quadratically looping would be a chunky rewrite of the query builder, but we can locally refactor to be a bunch cheaper in terms of regexp operations. This change cuts the benchmark time here in ~half (yay!). We achieve this by simplifying the overall replacement regexp (we don't need our column names in there, since we already have a plain object where they're the keys to match against) so compilation of that is much cheaper, plus skipping the need to `escapeRegExp` every column as a result.
7 tasks
pleerock
pushed a commit
that referenced
this pull request
May 31, 2022
Digging further into #3857. See also #8955, #8956. As [previously discussed](#3857 (comment)), the query builder currently suffers from poor performance in two ways: quadratic numbers of operations with respect to total table/column counts, and poor constant factor performance (regexps can be expensive to build/run!) The constant-factor performance is the more tractable problem: no longer quadratically looping would be a chunky rewrite of the query builder, but we can locally refactor to be a bunch cheaper in terms of regexp operations. This change cuts the benchmark time here in ~half (yay!). We achieve this by simplifying the overall replacement regexp (we don't need our column names in there, since we already have a plain object where they're the keys to match against) so compilation of that is much cheaper, plus skipping the need to `escapeRegExp` every column as a result.
draaglom
added a commit
to loyaltylion/typeorm
that referenced
this pull request
May 31, 2022
Context: the query builder is pretty CPU intensive, and can be slow - e.g. typeorm#3857 One of the things which makes this slow is `escapeRegExp` in the query builder: we freshly construct the same RegExp once per `replacePropertyName` invocation (many times per overall query!) and since the RegExp itself is constant -- we can lift it out and construct it once. Over-all this saves about 8% on our query build times as measured by typeorm#8955.
draaglom
added a commit
to loyaltylion/typeorm
that referenced
this pull request
May 31, 2022
Digging further into typeorm#3857. See also typeorm#8955, typeorm#8956. As [previously discussed](typeorm#3857 (comment)), the query builder currently suffers from poor performance in two ways: quadratic numbers of operations with respect to total table/column counts, and poor constant factor performance (regexps can be expensive to build/run!) The constant-factor performance is the more tractable problem: no longer quadratically looping would be a chunky rewrite of the query builder, but we can locally refactor to be a bunch cheaper in terms of regexp operations. This change cuts the benchmark time here in ~half (yay!). We achieve this by simplifying the overall replacement regexp (we don't need our column names in there, since we already have a plain object where they're the keys to match against) so compilation of that is much cheaper, plus skipping the need to `escapeRegExp` every column as a result.
frangz
pushed a commit
to loyaltylion/typeorm
that referenced
this pull request
Nov 14, 2022
Context: the query builder is pretty CPU intensive, and can be slow - e.g. typeorm#3857 One of the things which makes this slow is `escapeRegExp` in the query builder: we freshly construct the same RegExp once per `replacePropertyName` invocation (many times per overall query!) and since the RegExp itself is constant -- we can lift it out and construct it once. Over-all this saves about 8% on our query build times as measured by typeorm#8955.
frangz
pushed a commit
to loyaltylion/typeorm
that referenced
this pull request
Nov 14, 2022
Digging further into typeorm#3857. See also typeorm#8955, typeorm#8956. As [previously discussed](typeorm#3857 (comment)), the query builder currently suffers from poor performance in two ways: quadratic numbers of operations with respect to total table/column counts, and poor constant factor performance (regexps can be expensive to build/run!) The constant-factor performance is the more tractable problem: no longer quadratically looping would be a chunky rewrite of the query builder, but we can locally refactor to be a bunch cheaper in terms of regexp operations. This change cuts the benchmark time here in ~half (yay!). We achieve this by simplifying the overall replacement regexp (we don't need our column names in there, since we already have a plain object where they're the keys to match against) so compilation of that is much cheaper, plus skipping the need to `escapeRegExp` every column as a result.
7 tasks
frangz
pushed a commit
to loyaltylion/typeorm
that referenced
this pull request
Nov 14, 2022
Context: the query builder is pretty CPU intensive, and can be slow - e.g. typeorm#3857 One of the things which makes this slow is `escapeRegExp` in the query builder: we freshly construct the same RegExp once per `replacePropertyName` invocation (many times per overall query!) and since the RegExp itself is constant -- we can lift it out and construct it once. Over-all this saves about 8% on our query build times as measured by typeorm#8955.
frangz
pushed a commit
to loyaltylion/typeorm
that referenced
this pull request
Nov 14, 2022
Digging further into typeorm#3857. See also typeorm#8955, typeorm#8956. As [previously discussed](typeorm#3857 (comment)), the query builder currently suffers from poor performance in two ways: quadratic numbers of operations with respect to total table/column counts, and poor constant factor performance (regexps can be expensive to build/run!) The constant-factor performance is the more tractable problem: no longer quadratically looping would be a chunky rewrite of the query builder, but we can locally refactor to be a bunch cheaper in terms of regexp operations. This change cuts the benchmark time here in ~half (yay!). We achieve this by simplifying the overall replacement regexp (we don't need our column names in there, since we already have a plain object where they're the keys to match against) so compilation of that is much cheaper, plus skipping the need to `escapeRegExp` every column as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Context: the query builder is pretty CPU intensive, and can be slow -
e.g. #3857
One of the things which makes this slow is
escapeRegExpin the querybuilder: we freshly construct the same RegExp once per
replacePropertyNameinvocation (many times per overall query!) andsince the RegExp itself is constant -- we can lift it out and construct
it once.
Over-all this saves about 5% on our query build times as measured by
#8955.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000