Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to entity property if referencedColumn returns nothing #9572

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: fallback to entity property if referencedColumn returns nothing #9572

wants to merge 4 commits into from

Commits on Nov 26, 2022

  1. test: add suite for issue 9565

    @akwodkiewicz
    akwodkiewicz committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    f1efc6c View commit details
    Browse the repository at this point in the history

  2. refactor: remove unnecessary check 

    Both composite boolean expressions check if the value is an object.
This means that value can never be of type "function", so these checks
can be removed.
    @akwodkiewicz
    akwodkiewicz committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    a63b9f7 View commit details
    Browse the repository at this point in the history

  3. refactor: extract repeated predicate to isEntityLike method 

    This predicate occurs a couple of times in getEntityValue method.
I tried to deduce its value (isEntityLike) from its usage.

This refactor is not 100% pure, because I incorporated

    !(val instanceof Date)

expression into the method, even though it was mentioned in 2 out of 4
places that were replaced with the method call.

Again, studying the usage of the predicate, I decided that making sure
if the value is not a Date will only make the assumption more correct in
those 2 other places, because next operations assume that the value is
an entity.
    @akwodkiewicz
    akwodkiewicz committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    cc8d76b View commit details
    Browse the repository at this point in the history

  4. fix: fallback to entity property if referencedColumn returns nothing

    @akwodkiewicz
    akwodkiewicz committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    795c74d View commit details
    Browse the repository at this point in the history