Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Lists ✭ That Wrap Like A Glove #89

Open
grayghostvisuals opened this issue Mar 20, 2013 · 6 comments
Open

Responsive Lists ✭ That Wrap Like A Glove #89

grayghostvisuals opened this issue Mar 20, 2013 · 6 comments

Comments

@grayghostvisuals
Copy link
Contributor

Check this codepen from @TrentWalton
http://codepen.io/TrentWalton/pen/skBnz

Basically the lists are being used like this...

ul li a {
    line-height: 2; // not a good approach
}

ul li a {
   line-height: 1.25; // a better approach
   padding: 0.375em 0; // padding used is the remaining amount from the computed line height / 2
}
@jhogue
Copy link

jhogue commented Apr 9, 2013

No one asked me, but adding padding to <a> as often as possible results in a larger touchable area, which is the best thing to do. So this is good practice in general, in my mind.

I know the intention here is to visually group any multi-line <li> elements, which is a very nice approach, so, sorry to get off topic a bit. Thumbs up.

@grayghostvisuals
Copy link
Contributor Author

@jhogue If you'd like we can make you a core contrib and member for the project with pull access and eventually leading to both push and pull in the future?

@jhogue
Copy link

jhogue commented Apr 9, 2013

Hey, that'd be great. And an honor. If you trust me to do the right thing
(as I try to do) then grant away.

On Tue, Apr 9, 2013 at 2:47 PM, Dennis Gaebel notifications@github.comwrote:

@jhogue https://github.com/jhogue If you'd like we can make you a core
contrib and member for the project with pull access and eventually leading
to both push and pull in the future?


Reply to this email directly or view it on GitHubhttps://github.com//issues/89#issuecomment-16132177
.

J. Hogue: Design Director at Project Evolution
t: 888.456.0467 | c: 401.831.1963

@grayghostvisuals
Copy link
Contributor Author

Ok you're in the cool kids club! \m/ As your contributing increases we'll update privs to full push and pull. 🙀

@jhogue
Copy link

jhogue commented Apr 10, 2013

Thanks man. I'll try and make y'all proud. You've got a great little thing
here, and I respect it. Thanks for the privileges.

On Tue, Apr 9, 2013 at 3:12 PM, Dennis Gaebel notifications@github.comwrote:

Ok you're in the cool kids club! \m/ As your contributing increases we'll
update privs to full push and pull. [image: 🙀]


Reply to this email directly or view it on GitHubhttps://github.com//issues/89#issuecomment-16133735
.

J. Hogue: Design Director at Project Evolution
t: 888.456.0467 | c: 401.831.1963

@grayghostvisuals
Copy link
Contributor Author

Absolutely! Lookin' forward to having you aboard for the ride. Let's make this thing "awesome-er" 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants