fix(queryTypes) use enums instead of object for ambient context

[modulitos]

Fixes #138

[felixfbecker]

this is wrong. Those are not numeric enums, they are strings. A string enum would work

[modulitos]

@felixfbecker Thanks for the correction. I'm pushing up a fix now to make this a string enum.

I appreciate the feedback 👍

[felixfbecker]

it should be exported, not declared as a global

[modulitos]

I tried that by using export default enum QueryTypes { .... but the compiler complains with the message Expression expected. [1109].

It doesn't seem like I can use const enum QueryTypes {.. followed by export default QueryTypes either, because of the error: A 'declare' modifier is required for a top level declaration in a .d.ts file. [1046].

Any suggestions?

[modulitos]

Ah, I see. I think I can use export enum QueryTypes {... here. I'll push up a fix....

[felixfbecker]

Please make sure to mirror the export style in the Sequelize library.

[modulitos]

Are you referring to me using export default ... instead of export ...? If so, that makes sense and I'll push up a fix soon.

If you are referring to something else in the library, then let me know if I'm missing anything.

[felixfbecker]

The QueryTypes are exported with export =. Please maintain that.

https://github.com/sequelize/sequelize/blob/089504fe417310265c7823acb33ca6d2b0d4d2b6/lib/query-types.js#L23

[modulitos]

@felixfbecker I'm not sure that I can export my enum using the export = assignment without declaring my enum globally. When I try the following:

enum QueryTypes {
  SELECT = "SELECT",
  INSERT = "INSERT",
  UPDATE = "UPDATE",
  BULKUPDATE = "BULKUPDATE",
  BULKDELETE = "BULKDELETE",
  DELETE = "DELETE",
  UPSERT = "UPSERT",
  VERSION = "VERSION",
  SHOWTABLES = "SHOWTABLES",
  SHOWINDEXES = "SHOWINDEXES",
  DESCRIBE = "DESCRIBE",
  RAW = "RAW",
  FOREIGNKEYS = "FOREIGNKEYS",
}

module.exports = QueryTypes

I get the following error: A 'declare' modifier is required for a top level declaration in a .d.ts file. [1046].

And when I try:

module.exports = enum {
  SELECT = "SELECT",
  INSERT = "INSERT",
  UPDATE = "UPDATE",
  BULKUPDATE = "BULKUPDATE",
  BULKDELETE = "BULKDELETE",
  DELETE = "DELETE",
  UPSERT = "UPSERT",
  VERSION = "VERSION",
  SHOWTABLES = "SHOWTABLES",
  SHOWINDEXES = "SHOWINDEXES",
  DESCRIBE = "DESCRIBE",
  RAW = "RAW",
  FOREIGNKEYS = "FOREIGNKEYS",
}

I get this error: Expression expected. [1109].

Since enums are types and cannot be assigned within an expression, this seems to be the same reason why we are using export interface ... instead of exports = interface ....

What do you think?

[felixfbecker]

Did you try

enum QueryTypes { ... }
export = QueryTypes

[modulitos]

Yes, and I get the same A 'declare' modifier is required for a top level declaration in a .d.ts file. [1046] error

[felixfbecker]

this is not how it is in the source file.
Please add back export = QueryTypes at the bottom.

[modulitos]

As described in my comment here: #141 (comment) using export = QueryTypes causes a compiler error.

It seems like the only other option is to declare QueryTypes globally using declare enum QueryTypes as done in this commit.

I am fairly new to Typescript, so perhaps I'm missing something. Why are we trying to mirror the export style in the Sequelize library?