Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't duplicate action defaults #15

Closed
krzema12 opened this issue Jan 17, 2022 · 0 comments
Closed

Don't duplicate action defaults #15

krzema12 opened this issue Jan 17, 2022 · 0 comments
Assignees
@krzema12
Milestone
v0.4.0

Comments

@krzema12
Copy link
Member

krzema12 commented Jan 17, 2022 •
edited

See e.g. here:

https://github.com/krzema12/github-actions-kotlin-dsl/blob/50f28297b605964bb87ca2926ac66957d9dee749/library/src/main/kotlin/it/krzeminski/githubactions/actions/Checkout.kt#L13

If the user doesn't specify fetchDepth, we now set 1 here in the library, but it's actually the default value of this action. In case someone doesn't specify fetchDepth, we shouldn't put related key in the resulting YAML, thus allowing the action's default to kick in.
@krzema12 krzema12 self-assigned this Jan 22, 2022
@krzema12 krzema12 added this to the v0.4.0 milestone Jan 23, 2022
krzema12 added a commit that referenced this issue Jan 23, 2022
@krzema12
[#15] Remove default for Checkout's 'fetch-depth'
16fbcd3 
The default is now achieved by not emitting 'fetch-depth' key in YAML,
so the action itself uses its default.
krzema12 added a commit that referenced this issue Jan 23, 2022
@krzema12
[#15] Remove default for Checkout's 'fetch-depth'
bdf8546 
The default is now achieved by not emitting 'fetch-depth' key in YAML,
so the action itself uses its default.
krzema12 added a commit that referenced this issue Jan 23, 2022
@krzema12
[#15] Remove default for Checkout's 'fetch-depth'
39e58c1 
The default is now achieved by not emitting 'fetch-depth' key in YAML,
so the action itself uses its default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzema12 krzema12

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@krzema12