Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolver error reporting #478

Closed
fsat opened this issue May 30, 2017 · 2 comments
Closed

Improve resolver error reporting #478

fsat opened this issue May 30, 2017 · 2 comments

Comments

@fsat
Copy link
Contributor

fsat commented May 30, 2017

At the moment, if the bundle is not found, each resolver will return False, None, None which corresponds to something is not found (False), the file name (None), and the full path to the artefact (None).

In the event of error, at the moment False, None, None will be returned and no exception will be raised to allow for the next resolver in the chain to continue.

However I’m thinking of adding another argument which contains list of possible errors encountered during resolution.

For example, uri_resolver encounters HTTPError, it will return False, None, None, [http_error_instance], vs False, None, None, [] if the artefact is simply not found. If all is well, it will return True, file_name, file_path, [].

This way it’s possible to continue through the resolver chain, collect the possible errors that could happen, and if the bundle is indeed not found and if there are errors, we can display those.

@fsat
Copy link
Contributor Author

fsat commented May 30, 2017

@fsat
Copy link
Contributor Author

fsat commented Jun 13, 2017

Fixed via #485

@fsat fsat closed this as completed Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant