Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move everything in project/*.scala to .sbt where possible #132

Closed
havocp opened this issue Jan 7, 2014 · 3 comments
Closed

move everything in project/*.scala to .sbt where possible #132

havocp opened this issue Jan 7, 2014 · 3 comments

Comments

@havocp
Copy link
Collaborator

havocp commented Jan 7, 2014

No description provided.

@skrauchenia
Copy link

So you want to migrate Buils.scala and JavaVersionCheck.scala to *.sbt? Is there is some compelling reason to do so?

@havocp
Copy link
Collaborator Author

havocp commented Dec 15, 2014

In general, things that don't make sense in .sbt should be plugins, or treated as if they were plugins (for example the sonatype stuff could be its own .scala file and then configured/used in .sbt). javaversioncheck is now available as a plugin already: https://github.com/sbt/sbt-javaversioncheck

There is not a super compelling reason to do this though, no. .sbt files are the suggested way in new code but it isn't actively breaking anything to use the .scala file. So that's why it is tagged "would-be-nice cleanup" ;-)
I have a lot of issues I'd work on first.

@havocp
Copy link
Collaborator Author

havocp commented Mar 7, 2015

This is probably kind of pointless to leave open; the build is fine for now. Closing my own issue.

@havocp havocp closed this as completed Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants