Topic/fix test classpath #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dotta
commented
May 25, 2012
dotta
commented
- This fix the issue with the failing test (this was a side effect of re-writing git's history)
- I've also made a few minor changes here and there.
The run config in build.sbt was not updated after the packaging refactoring done in SHA #53725d0607aa339af020a75c465208416f3a9a00.
….e. use %% instead of %)
The issue was that the test runner (i.e., ``CollectProblemsTest``), had an hardcoded reference to the Scala library, which is needed to correctly run the test. However, due to recent git-history re-writing (which has considerably reduced the repo's size), the Scala library JAR referenced in the test was no longer available. The fix is to pass the ``testClasspath`` to the test runner, and at the moment the ``testClasspath`` only contains a reference to the Scala library's path used to build the project itself.
| oraclePath: String): Unit | ||
| }] | ||
|
|
||
| // Add the scala-library to the MiMa classpath used to run this test | ||
| val testClasspath = data(cp).filter(_.getName endsWith "scala-library.jar").map(_.getAbsolutePath).toList |
There was a problem hiding this comment.
Josh, is there a better way to express this?
There was a problem hiding this comment.
Maybe if you use scalaInstance. Not worth it perhaps....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.