Topic/fix test classpath #7

Merged
merged 4 commits into from May 25, 2012

2 participants

@dotta
  • This fix the issue with the failing test (this was a side effect of re-writing git's history)
  • I've also made a few minor changes here and there.
dotta added some commits May 25, 2012
@dotta dotta Missed SBT run config in package refactoring
The run config in build.sbt was not updated after the packaging refactoring
done in SHA #53725d0607aa339af020a75c465208416f3a9a00.
b06c673
@dotta dotta Updated Mirco's id in Build.scala 1ae2088
@dotta dotta Let SBT figure out the right Scala version to use for dependencies (i…
….e. use %% instead of %)
04f00e0
@dotta dotta Fixed failing test
The issue was that the test runner (i.e., ``CollectProblemsTest``), had an
hardcoded reference to the Scala library, which is needed to correctly run the
test. However, due to recent git-history re-writing (which has considerably
reduced the repo's size), the Scala library JAR referenced in the test was no
longer available.

The fix is to pass the ``testClasspath`` to the test runner, and at the moment
the ``testClasspath`` only contains a reference to the Scala library's path
used to build the project itself.
0e6fa08
@dotta dotta commented on the diff May 25, 2012
project/Build.scala
oraclePath: String): Unit
}]
+ // Add the scala-library to the MiMa classpath used to run this test
+ val testClasspath = data(cp).filter(_.getName endsWith "scala-library.jar").map(_.getAbsolutePath).toList
@dotta
dotta added a line comment May 25, 2012

Josh, is there a better way to express this?

@jsuereth
jsuereth added a line comment May 25, 2012

Maybe if you use scalaInstance. Not worth it perhaps....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jsuereth jsuereth merged commit 40bbcf5 into typesafehub:master May 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment