Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RulesDirectory using a relative path #151

Closed
razzeee opened this issue Sep 18, 2019 · 3 comments
Closed

RulesDirectory using a relative path #151

razzeee opened this issue Sep 18, 2019 · 3 comments
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@razzeee
Copy link

razzeee commented Sep 18, 2019

🐛 Bug Report

  • tslint-to-eslint-config version: X.X.X current one used by NPX
  • ESLint version: X.X.X not installed yet
  • Node version: 10.16.3

Actual Behavior

eslintrc.js get's generated, but the rulesDirectory field in the @typescript-eslint/tslint/config object is using an absolute path.

Expected Behavior

It should be figuring out the relative path and be using this. As that's the only path, that will work on another PC.

Reproduction

Ran it against master of https://github.com/elm-tooling/elm-language-client-vscode but I don't think it's affected by the project in this case.

@JoshuaKGoldberg
Copy link
Member

Agreed, thanks for filing this @razzeee! Accepting PRs to make that change.

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working labels Sep 18, 2019
@JoshuaKGoldberg JoshuaKGoldberg added this to the 1.0 Ready 🚀 milestone Oct 20, 2019
@KingDarBoja
Copy link
Collaborator

I tried to reproduce the issue but got no rulesDirectory on the @typescript-eslint/tslint/config object.

@razzeee
Copy link
Author

razzeee commented Apr 22, 2020

I think this is solved as this tool now seems to write rules instead.

@razzeee razzeee closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants