Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"do not have an ESLint equivalent" is misleading #299

Closed
JoshuaKGoldberg opened this issue Dec 22, 2019 · 0 comments · Fixed by #308
Closed

"do not have an ESLint equivalent" is misleading #299

JoshuaKGoldberg opened this issue Dec 22, 2019 · 0 comments · Fixed by #308
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working

Comments

@JoshuaKGoldberg
Copy link
Member

🐛 Bug Report

  • tslint-to-eslint-config version: 0.4.0
  • ESLint version: N/A
  • Node version: N/A

Actual Behavior

When a TSLint configuration contains a rule not recognized by tslint-to-eslint-config, the message is in the format:

some-tslint-rule does not yet have an ESLint equivalent

This is actually kind of misleading; the issue could alternately be that this tool doesn't yet know of the ESLint equivalent. 🙁

Expected Behavior

The messaging should be something like, maybe...

tslint-to-eslint-config does not know the ESLint equivalent for TSLint's some-tslint-rule

Reproduction

Create a tslint.json file with:

{
    "rules": { "my-custom-rule": true }
}

Then run:

npx tslint-to-eslint-config@0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
1 participant