Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include output rule disables if disabled by a plugin #5

Closed
JoshuaKGoldberg opened this issue Jun 24, 2019 · 1 comment
Closed

Don't include output rule disables if disabled by a plugin #5

JoshuaKGoldberg opened this issue Jun 24, 2019 · 1 comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Member

For example, after #4, many generated ESLint configs will extend from eslint-plugin-prettier. There'll be no need to disable whitespace rules that are already disabled.

I believe this will require something like require-ing plugins to get rule settings from them...
@JoshuaKGoldberg JoshuaKGoldberg added type: enhancement New feature or request status: accepting prs Please, send in a PR to resolve this! ✨ labels Jun 24, 2019
@JoshuaKGoldberg JoshuaKGoldberg changed the title Don't disable output rules if not enabled by a plugin Don't include output rule disables if disabled by a plugin Jun 25, 2019
This was referenced Jun 25, 2019
Closed
Closed
Closed
@JoshuaKGoldberg
Copy link
Member Author

I believe this was actually fixed by #78 as a subset of #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg