Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider TSLint rules enabled by eslint-plugin-tslint #57

Closed
JoshuaKGoldberg opened this issue Jul 1, 2019 · 0 comments · Fixed by #124
Closed

Consider TSLint rules enabled by eslint-plugin-tslint #57

JoshuaKGoldberg opened this issue Jul 1, 2019 · 0 comments · Fixed by #124
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Milestone
1.0 Ready 🚀

Comments

@JoshuaKGoldberg
Copy link
Member

🚀 Feature Request

ESLint configurations might already enable TSLint rules under eslint-plugin-tslint.

Existing Behavior

Only tslint.json is considered as a source of truth.

Change Proposal

When creating the list of enabled TSLint rules, apply any rules listed under eslint-plugin-tslint on top of tslint.json rules.

Related: #5, #34.
@JoshuaKGoldberg JoshuaKGoldberg added type: enhancement New feature or request status: accepting prs Please, send in a PR to resolve this! ✨ good first issue Good for newcomers; welcome aboard! labels Jul 1, 2019
@JoshuaKGoldberg JoshuaKGoldberg added this to the 1.0 Ready 🚀 milestone Jul 1, 2019
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 1, 2019
Closed
@JoshuaKGoldberg JoshuaKGoldberg changed the title Consider TSLint rules enabled by eslint-plugin-tslin Consider TSLint rules enabled by eslint-plugin-tslint Jul 5, 2019
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 28, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Milestone
1.0 Ready 🚀
Development

Successfully merging a pull request may close this issue.

Included ESLint configuration in TSLint rules list typescript-eslint/tslint-to-eslint-config
1 participant
@JoshuaKGoldberg