Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prefer-array-literal converter #1009

Merged
merged 4 commits into from
May 17, 2021
Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 29, 2021

PR Checklist

Overview

No rule options. Nice and easy.

No rule options. Nice and easy.
@JoshuaKGoldberg JoshuaKGoldberg changed the title Added prefer-array-literal constructor Added prefer-array-literal converter Mar 31, 2021
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the typescript-eslint no-array-constructor documentation, we should also turn off the eslint rule "no-array-constructor": "off", to avoid reporting incorrect errors 🤔

@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked We can't make progress on this issue until something else is resolved... label Apr 19, 2021
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author The PR author should address requested changes and removed status: blocked We can't make progress on this issue until something else is resolved... labels May 16, 2021
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels May 17, 2021
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toasty 🥖

@JoshuaKGoldberg JoshuaKGoldberg merged commit a954b7a into main May 17, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-array-literal branch May 17, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tslint-microsoft-contrib converter: prefer-array-literal
2 participants