Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-conditional-expression converter #1060

Merged
merged 1 commit into from
May 16, 2021
Merged

Add prefer-conditional-expression converter #1060

merged 1 commit into from
May 16, 2021

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

Not 100% sure if it checks nested "if-else-if" statements but based on the eslint plugin docs, does seem to only check simple "if-else" cases.

@KingDarBoja KingDarBoja added the status: waiting for reviewer Waiting for a maintainer to review label May 16, 2021
@KingDarBoja KingDarBoja self-assigned this May 16, 2021
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, I forgot this rule existed... great!

@JoshuaKGoldberg JoshuaKGoldberg merged commit f12bdbc into typescript-eslint:main May 16, 2021
@KingDarBoja KingDarBoja deleted the converter/unicorn-prefer-conditional-expression branch May 17, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

@KingDarBoja KingDarBoja

Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Converter for prefer-conditional-expression
2 participants
@KingDarBoja @JoshuaKGoldberg