Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update converter to return PascalCase and snake_case format values for variable names #1526

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix: update converter to return PascalCase and snake_case format values for variable names #1526

merged 1 commit into from
Jul 22, 2022

Conversation

amorimr
Copy link
Contributor

@amorimr amorimr commented Jul 6, 2022

PR Checklist

Overview

Updates the variable-name rule converter to return PascalCase and snake_case as formats if those are present in the rules to be converted.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7978dc4 into typescript-eslint:main Jul 22, 2022
@amorimr amorimr deleted the fix-1442 branch July 22, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amorimr @JoshuaKGoldberg