Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore all unknown editor settings in conversion #650

Merged
merged 1 commit into from Jul 29, 2020
Merged

Ignore all unknown editor settings in conversion #650

merged 1 commit into from Jul 29, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 25, 2020 •
edited

PR Checklist

Overview

Uses an explicit allowlist for the known editor settings mentioned in the TSLint extension's docs instead of prefix filtering.

FYI @MrCube42

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft July 25, 2020 19:32
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the ignore-all-unknown-editor-settings branch from c1677c2 to 2fc9dc2 Compare July 25, 2020 19:33
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 25, 2020 19:34
KingDarBoja
KingDarBoja approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock and roll 🎸 🥌

@KingDarBoja KingDarBoja added the type: enhancement New feature or request label Jul 25, 2020
@KingDarBoja KingDarBoja added this to the Version 1.1 milestone Jul 25, 2020
@JoshuaKGoldberg JoshuaKGoldberg merged commit 02ac0f7 into master Jul 29, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the ignore-all-unknown-editor-settings branch July 29, 2020 01:32
@JoshuaKGoldberg JoshuaKGoldberg restored the ignore-all-unknown-editor-settings branch August 9, 2020 16:07
@JoshuaKGoldberg JoshuaKGoldberg deleted the ignore-all-unknown-editor-settings branch August 9, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
Version 1.1
Development

Successfully merging this pull request may close these issues.

VS Code settings unrelated to TSLint->ESLint should be ignored
2 participants
@JoshuaKGoldberg @KingDarBoja