Merge branch 'main' into 8428-export-utility-to-remove-type-info

.github/ISSUE_TEMPLATE/06-bug-report-other.yaml

@@ -20,7 +20,11 @@ body:
         - label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed.
           required: true
   - type: markdown
-    id: complexity-note
+    attributes:
+      value: |
+        **All typescript-eslint bug reports need an isolated reproduction** we can clone locally and get running without other projects or existing knowledge of your project.
+        If you can't provide one, your report will likely be closed without action.
+  - type: markdown
     attributes:
       value: |
         ### Note For Complex Issues

.github/workflows/lock.yml

@@ -14,8 +14,9 @@ jobs:
 
     runs-on: ubuntu-latest
     steps:
-      - uses: dessant/lock-threads@v4
+      - uses: dessant/lock-threads@v5.0.1
         with:
+          add-issue-labels: 'locked due to age'
           github-token: ${{ github.token }}
           issue-inactive-days: '7'
           issue-lock-reason: 'resolved'

.github/workflows/pr-labels.yml

@@ -0,0 +1,25 @@
+name: Pull Request Labels
+
+on:
+  pull_request:
+    types: [labeled, opened, synchronize, unlabeled]
+
+jobs:
+  label:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      pull-requests: write
+    steps:
+      - id: changed-stable-configs
+        uses: tj-actions/changed-files@v44.5.2
+        with:
+          files: packages/{eslint-plugin,typescript-eslint}/src/configs/{recommended,stylistic}*
+      - if: steps.changed-stable-configs.outputs.any_changed == 'true'
+        uses: mheap/github-action-required-labels@v5.4.1
+        with:
+          add_comment: true
+          count: 1
+          labels: breaking change
+          message: '🤖 Beep boop! PRs that change our stable preset configs must be labeled with `breaking change`.'
+          mode: minimum

CHANGELOG.md

@@ -1,3 +1,36 @@
+## 7.12.0 (2024-06-03)
+
+
+### 🚀 Features
+
+- **eslint-plugin:** [no-useless-template-literals] rename to `no-useless-template-expression` (deprecate `no-useless-template-literals`) ([#8821](https://github.com/typescript-eslint/typescript-eslint/pull/8821))
+- **eslint-plugin:** [no-floating-promises] add option 'allowForKnownSafePromises' ([#9186](https://github.com/typescript-eslint/typescript-eslint/pull/9186))
+- **rule-tester:** check for parsing errors in suggestion fixes ([#9052](https://github.com/typescript-eslint/typescript-eslint/pull/9052))
+- **rule-tester:** port `checkDuplicateTestCases` from ESLint ([#9026](https://github.com/typescript-eslint/typescript-eslint/pull/9026))
+
+### 🩹 Fixes
+
+- no-useless-template-expression -> no-unnecessary-template-expression ([#9174](https://github.com/typescript-eslint/typescript-eslint/pull/9174))
+- **eslint-plugin:** [no-unnecessary-type-assertion] combine template literal check with `const` variable check ([#8820](https://github.com/typescript-eslint/typescript-eslint/pull/8820))
+- **eslint-plugin:** [dot-notation] fix false positive when accessing private/protected property with optional chaining ([#8851](https://github.com/typescript-eslint/typescript-eslint/pull/8851))
+- **eslint-plugin:** [explicit-member-accessibility] refine report locations ([#8869](https://github.com/typescript-eslint/typescript-eslint/pull/8869))
+- **eslint-plugin:** [no-unnecessary-type-assertion] declares are always defined, so always check `declare`s ([#8901](https://github.com/typescript-eslint/typescript-eslint/pull/8901))
+- **eslint-plugin:** [prefer-literal-enum-member] allow using member it self on allowBitwiseExpressions ([#9114](https://github.com/typescript-eslint/typescript-eslint/pull/9114))
+- **eslint-plugin:** [return-await] clean up in-try-catch detection and make autofixes safe ([#9031](https://github.com/typescript-eslint/typescript-eslint/pull/9031))
+- **eslint-plugin:** [member-ordering] also TSMethodSignature can be get/set ([#9193](https://github.com/typescript-eslint/typescript-eslint/pull/9193))
+- **types:** correct typing ParserOptions ([#9202](https://github.com/typescript-eslint/typescript-eslint/pull/9202))
+
+### ❤️  Thank You
+
+- Abraham Guo
+- Han Yeong-woo @nix6839
+- Joshua Chen
+- Kim Sang Du @developer-bandi
+- Kirk Waiblinger
+- YeonJuan @yeonjuan
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 7.11.0 (2024-05-27)
 
 

docs/Contributing.mdx

@@ -16,6 +16,6 @@ If you're new to open source, you may also find the [How to Contribute to Open S
 
 ## Next Steps
 
-1. [Finding or opening an issue](./contributing/Issues.mdx): In the issue tab, find the pr currently tagged with `accepting prs` or create a new issue.
-2. [Setting up a local environment](./contributing/Local_Development.mdx): Let's learn how to set up the local environment to start development.
-3. [Making a PR](./contributing/Pull_Requests.mdx): you've got changes locally that address an issue, take a look at that topic.
+1. [Finding or opening an issue](./contributing/Issues.mdx): In the issue tab, finding or creating an issue to work on.
+2. [Setting up a local environment](./contributing/Local_Development.mdx): Learning how to set up the local environment to start development.
+3. [Making a PR](./contributing/Pull_Requests.mdx): Sending in your changes to resolve an accepted issue.

docs/contributing/Issues.mdx

@@ -34,6 +34,13 @@ We've found in the past that they result in accidental ["licked cookie"](https:/
 If an issue has been marked as `accepting prs` and an open PR does not exist, feel free to send a PR.
 You don't need to ask for permission.
 
+## Finding Issues
+
+Consider searching through:
+
+1. [Unassigned user-facing marked as `accepting prs` and `good first issue`](https://github.com/typescript-eslint/typescript-eslint/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+label%3A%22accepting+prs%22+-label%3A%22repo+maintenance%22+no%3Aassignee): to find issues marked as good for a first-timer
+2. [Unassigned user-facing marked as `accepting prs` without `good first issue`](https://github.com/typescript-eslint/typescript-eslint/issues?q=is%3Aopen+is%3Aissue+label%3A%22accepting+prs%22+-label%3A%22good+first+issue%22+-label%3A%22repo+maintenance%22+no%3Aassignee): once you've finished a few issues, to find more intermediate-level issues
+
 ## Questions and Support Requests
 
 The issue tracker is not an appropriate place for questions or support requests.

docs/maintenance/issues/Rule_Deprecations.mdx → docs/maintenance/issues/Rule_Deprecations_And_Deletions.mdx

@@ -1,6 +1,6 @@
 ---
-id: rule-deprecations
-title: Rule Deprecations
+id: rule-deprecations-and-deletions
+title: Rule Deprecations, Renames, And Deletions
 ---
 
 Sometimes a rule that used to be 👍 does not age well and becomes 👎.
@@ -14,12 +14,12 @@ In these cases, we aim to remove the old rule with minimal user disruption.
 
 ## Filing the Issue
 
-Rule deprecations can be filed as a [new issue bypassing templates](https://github.com/typescript-eslint/typescript-eslint/issues/new).
+Rule deprecations and renames can be filed as a [new issue bypassing templates](https://github.com/typescript-eslint/typescript-eslint/issues/new).
 
 Provide it an `## Overview` containing:
 
 - The rule name & link to its documentation page
-- A clear explanation of why you believe it should be deprecated
+- A clear explanation of why you believe it should be deprecated and/or renamed
 - Whether it exists in popular configs such as `eslint-config-airbnb-typescript` and `eslint-config-standard-with-typescript`
 - Sourcegraph queries showing how often it appears in user configs
 
@@ -30,5 +30,8 @@ Provide it an `## Overview` containing:
 1. In any minor/patch version, add [rule `meta` properties](https://eslint.org/docs/latest/developer-guide/working-with-rules#rule-basics):
    - `deprecated: true`
    - `replacedBy`, if applicable
-2. In the next major version, you may delete the rule
-   - If the rule is relatively popular with users, consider leaving a documentation page as a tombstone pointing to the new relevant rule or docs (see [`camelcase`](/rules/camelcase/) as an example)
+2. Search through open issues and PRs, and update the name in them accordingly:
+   - Deletions: close them with a link to the issue and deprecation PR
+   - Renames: update their title and explicitly mention in a comment that the rule has been renamed
+3. In the next major version, you may delete the deprecated rule
+   - Leave a documentation page as a tombstone pointing to the new relevant rule or docs (see [`camelcase`](/rules/camelcase) as an example)

docs/maintenance/pull-requests/Dependency_Version_Upgrades.mdx

@@ -134,6 +134,7 @@ We generally start the process of supporting a new TypeScript version just after
    - Whenever a PR is merged, change the respective heading's emoji from 🏗 to ✅
 1. Create a PR with a title like `feat: update TypeScript to X.Y-rc` and the following changes:
    - In the root `package.json`, add `|| X.Y.1-rc2` to the `devDependency` on `typescript`
+   - In the parser's `getLib`, update the `switch (target)` and its preceding comment as needed (see [#6782](https://github.com/typescript-eslint/typescript-eslint/pull/6782))
    - Change the `SUPPORTED_TYPESCRIPT_VERSIONS` constant's `<` version to the next version of TypeScript
    - Change the `SUPPORTED_PRERELEASE_RANGES` constant to equal `['X.Y.1-rc']`
    - Rename and update `patches/typescript*` to the new TypeScript version

docs/packages/ESLint_Plugin.mdx

@@ -5,6 +5,8 @@ sidebar_label: eslint-plugin
 
 # `@typescript-eslint/eslint-plugin`
 
+<PackageLink packageName="eslint-plugin" scope="@typescript-eslint" />
+
 > The TypeScript plugin for ESLint. ✨
 
 :::info

docs/packages/ESLint_Plugin_TSLint.mdx

@@ -5,6 +5,8 @@ sidebar_label: eslint-plugin-tslint
 
 # `@typescript-eslint/eslint-plugin-tslint`
 
+<PackageLink packageName="eslint-plugin-tslint" scope="@typescript-eslint" />
+
 > ESLint plugin that allows running TSLint rules within ESLint to help you migrate from TSLint to ESLint. ✨
 
 :::caution

docs/packages/Parser.mdx

@@ -3,8 +3,13 @@ id: parser
 sidebar_label: parser
 ---
 
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
 # `@typescript-eslint/parser`
 
+<PackageLink packageName="parser" scope="@typescript-eslint" />
+
 > An [ESLint parser](https://eslint.org/docs/user-guide/configuring/plugins#specifying-parser) used to parse TypeScript code into ESLint-compatible nodes, as well as provide backing TypeScript programs. ✨
 
 This is necessary because TypeScript produces a different, incompatible AST format to the one that ESLint requires to work.
@@ -310,7 +315,25 @@ An experimental alternative to `parserOptions.project`.
 This directs the parser to use a more seamless TypeScript API to generate type information for rules.
 It will automatically detect the TSConfig for each file (like `project: true`), and will also allow type information to be computed for JavaScript files without the `allowJs` compiler option (unlike `project: true`).
 
-```js
+<Tabs groupId="eslint-config">
+<TabItem value="Flat Config">
+
+```js title="eslint.config.js"
+export default [
+  {
+    languageOptions: {
+      parserOptions: {
+        EXPERIMENTAL_useProjectService: true,
+      },
+    },
+  },
+];
+```
+
+</TabItem>
+<TabItem value="Legacy Config">
+
+```js title=".eslintrc.js"
 module.exports = {
   parser: '@typescript-eslint/parser',
   parserOptions: {
@@ -319,6 +342,9 @@ module.exports = {
 };
 ```
 
+</TabItem>
+</Tabs>
+
 This option should bring two main benefits:
 
 - Simpler configurations: most projects shouldn't need to explicitly configure `project` paths or create `tsconfig.eslint.json`s
@@ -346,6 +372,24 @@ declare function createProgram(
 
 Example usage:
 
+<Tabs groupId="eslint-config">
+<TabItem value="Flat Config">
+
+```js title="eslint.config.js"
+import * as parser from '@typescript-eslint/parser';
+
+export default [
+  {
+    parserOptions: {
+      programs: [parser.createProgram('tsconfig.json')],
+    },
+  },
+];
+```
+
+</TabItem>
+<TabItem value="Legacy Config">
+
 ```js title=".eslintrc.js"
 const parser = require('@typescript-eslint/parser');
 
@@ -356,6 +400,9 @@ module.exports = {
 };
 ```
 
+</TabItem>
+</Tabs>
+
 ### `withoutProjectParserOptions(parserOptions)`
 
 Removes options that prompt the parser to parse the project with type information.
@@ -371,7 +418,7 @@ declare function withoutProjectParserOptions(
 
 Example usage:
 
-```js title=".eslintrc.js"
+```js title="somePlugin.js"
 const parser = require('@typescript-eslint/parser');
 
 function parse(path, content, context) {

docs/packages/Rule_Tester.mdx

@@ -7,6 +7,8 @@ import CodeBlock from '@theme/CodeBlock';
 
 # `@typescript-eslint/rule-tester`
 
+<PackageLink packageName="rule-tester" scope="@typescript-eslint" />
+
 > A utility for testing ESLint rules
 
 This is a fork of ESLint's built-in `RuleTester` to provide some better types and additional features for testing TypeScript rules.

docs/packages/Scope_Manager.mdx

@@ -5,6 +5,8 @@ sidebar_label: scope-manager
 
 # `@typescript-eslint/scope-manager`
 
+<PackageLink packageName="scope-manager" scope="@typescript-eslint" />
+
 > A fork of [`eslint-scope`](https://github.com/eslint/eslint-scope), enhanced to support TypeScript functionality. ✨
 
 A "scope analyser" traverses an AST and builds a model of how variables (and in our case, types) are defined and consumed by the source code.

docs/packages/TypeScript_ESLint.mdx

@@ -8,6 +8,8 @@ import TabItem from '@theme/TabItem';
 
 # `typescript-eslint`
 
+<PackageLink packageName="typescript-eslint" />
+
 > Tooling which enables you to use TypeScript with ESLint
 
 This package is the main entrypoint that you can use to consume our tooling with ESLint.

docs/packages/TypeScript_ESTree.mdx

@@ -5,6 +5,8 @@ sidebar_label: typescript-estree
 
 # `@typescript-eslint/typescript-estree`
 
+<PackageLink packageName="typescript-estree" scope="@typescript-eslint" />
+
 > The underlying code used by [`@typescript-eslint/parser`](./Parser.mdx) that converts TypeScript source code into an <a href="https://github.com/estree/estree">ESTree</a>-compatible form. ✨
 
 This parser is designed to be generic and robust.

docs/packages/Utils.mdx

@@ -5,6 +5,8 @@ sidebar_label: utils
 
 # `@typescript-eslint/utils`
 
+<PackageLink packageName="utils" scope="@typescript-eslint" />
+
 > Utilities for working with TypeScript + ESLint together. ✨
 
 This package contains public utilities for writing custom rules and plugins in TypeScript.

docs/users/Shared_Configurations.mdx

@@ -14,6 +14,9 @@ import TabItem from '@theme/TabItem';
 
 ## Getting Started
 
+See [Getting Started > Quickstart](../getting-started/Quickstart.mdx) first to set up your ESLint configuration file.
+[Packages > typescript-eslint](../packages/TypeScript_ESLint.mdx) includes more documentation on the `tseslint` helper.
+
 ### Projects Without Type Checking
 
 If your project does not enable [typed linting](../getting-started/Typed_Linting.mdx), we suggest enabling the [`recommended`](#recommended) and [`stylistic`](#stylistic) configurations to start:

eslint.config.mjs

@@ -103,9 +103,8 @@ export default tseslint.config(
       // make sure we're not leveraging any deprecated APIs
       'deprecation/deprecation': 'error',
 
-      // TODO(#7130): Investigate changing these in or removing these from presets
+      // TODO: https://github.com/typescript-eslint/typescript-eslint/issues/8538
       '@typescript-eslint/no-confusing-void-expression': 'off',
-      '@typescript-eslint/prefer-string-starts-ends-with': 'off',
 
       //
       // our plugin :D
@@ -142,6 +141,12 @@ export default tseslint.config(
           allowBitwiseExpressions: true,
         },
       ],
+      '@typescript-eslint/prefer-string-starts-ends-with': [
+        'error',
+        {
+          allowSingleElementEquality: 'always',
+        },
+      ],
       '@typescript-eslint/unbound-method': 'off',
       '@typescript-eslint/restrict-template-expressions': [
         'error',

packages/ast-spec/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 7.12.0 (2024-06-03)
+
+This was a version bump only for ast-spec to align it with other projects, there were no code changes.
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 7.11.0 (2024-05-27)
 
 

packages/ast-spec/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/ast-spec",
-  "version": "7.11.0",
+  "version": "7.12.0",
   "description": "Complete specification for the TypeScript-ESTree AST",
   "private": true,
   "keywords": [

packages/ast-spec/src/base/UnaryExpressionBase.ts

@@ -1,10 +1,8 @@
-import type { UnaryExpression } from '../expression/UnaryExpression/spec';
-import type { LeftHandSideExpression } from '../unions/LeftHandSideExpression';
-import type { Literal } from '../unions/Literal';
+import type { Expression } from '../unions/Expression';
 import type { BaseNode } from './BaseNode';
 
 export interface UnaryExpressionBase extends BaseNode {
   operator: string;
   prefix: boolean;
-  argument: LeftHandSideExpression | Literal | UnaryExpression;
+  argument: Expression;
 }