chore: replace manual typecheck targets with inferred ones

typescript-eslint · May 2, 2024 · 3983d44 · 3983d44
1 parent 353f925
commit 3983d44
Show file tree

Hide file tree

Showing 19 changed files with 23 additions and 45 deletions.
diff --git a/nx.json b/nx.json
@@ -1,6 +1,12 @@
 {
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
   "nxCloudAccessToken": "YjIzMmMxMWItMjhiMS00NWY2LTk1NWYtYWU3YWQ0YjE4YjBlfHJlYWQ=",
+  "plugins": [
+    {
+      "plugin": "@nx/js/typescript",
+      "exclude": ["*", "packages/integration-tests/fixtures/**"]
+    }
+  ],
   "release": {
     "projects": ["*"],
     "changelog": {

diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
@@ -36,8 +36,7 @@
     "clean-fixtures": "rimraf -g \"./src/**/fixtures/**/snapshots\"",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest"
   },
   "funding": {
     "type": "opencollective",

diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
@@ -10,8 +10,7 @@
     "postclean": "rimraf dist && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage"
   },
   "dependencies": {
     "@prettier/sync": "^0.5.1",

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -57,8 +57,7 @@
     "generate:configs": "npx nx run repo-tools:generate-configs",
     "lint": "npx nx lint",
     "test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --coverage --logHeapUsage",
-    "test-single": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --no-coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test-single": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --no-coverage"
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",

diff --git a/packages/integration-tests/package.json b/packages/integration-tests/package.json
@@ -5,8 +5,7 @@
   "scripts": {
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --no-coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --no-coverage"
   },
   "devDependencies": {
     "jest": "29.7.0",

diff --git a/packages/parser/package.json b/packages/parser/package.json
@@ -45,8 +45,7 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage"
   },
   "peerDependencies": {
     "eslint": "^8.56.0"

diff --git a/packages/repo-tools/package.json b/packages/repo-tools/package.json
@@ -12,8 +12,7 @@
     "generate-lib": "npx tsx ./src/generate-lib.mts",
     "lint": "npx nx lint",
     "postinstall-script": "npx tsx ./src/postinstall.mts",
-    "test": "npx jest --coverage",
-    "typecheck": "npx tsc -p tsconfig.json --noEmit"
+    "test": "npx jest --coverage"
   },
   "devDependencies": {
     "@nx/devkit": "*",

diff --git a/packages/rule-schema-to-typescript-types/package.json b/packages/rule-schema-to-typescript-types/package.json
@@ -30,8 +30,7 @@
     "generate-sponsors": "tsx ./src/generate-sponsors.ts",
     "lint": "npx nx lint",
     "postinstall-script": "tsx ./src/postinstall.ts",
-    "test": "npx jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "npx jest --coverage"
   },
   "dependencies": {
     "@typescript-eslint/type-utils": "7.8.0",

diff --git a/packages/rule-tester/package.json b/packages/rule-tester/package.json
@@ -43,8 +43,7 @@
     "lint": "npx nx lint",
     "pretest-eslint-base": "tsc -b tsconfig.build.json",
     "test-eslint-base": "mocha --require source-map-support/register ./tests/eslint-base/eslint-base.test.js",
-    "test": "npx jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "npx jest --coverage"
   },
   "//": "NOTE - AJV is out-of-date, but it's intentionally synced with ESLint - https://github.com/eslint/eslint/blob/ad9dd6a933fd098a0d99c6a9aa059850535c23ee/package.json#L70",
   "dependencies": {

diff --git a/packages/scope-manager/package.json b/packages/scope-manager/package.json
@@ -42,8 +42,7 @@
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "generate-lib": "npx nx generate-lib",
     "lint": "npx nx lint",
-    "test": "npx nx test --code-coverage",
-    "typecheck": "npx nx typecheck"
+    "test": "npx nx test --code-coverage"
   },
   "dependencies": {
     "@typescript-eslint/types": "7.8.0",

diff --git a/packages/scope-manager/project.json b/packages/scope-manager/project.json
@@ -18,17 +18,6 @@
         ]
       }
     },
-    "typecheck": {
-      "executor": "nx:run-commands",
-      "options": {
-        "parallel": true,
-        "cwd": "packages/scope-manager",
-        "commands": [
-          "tsc -p tsconfig.build.json --noEmit",
-          "tsc -p tsconfig.spec.json --noEmit"
-        ]
-      }
-    },
     "clean": {
       "executor": "nx:run-commands",
       "options": {

diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
@@ -42,8 +42,7 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage"
   },
   "dependencies": {
     "@typescript-eslint/typescript-estree": "7.8.0",

diff --git a/packages/types/package.json b/packages/types/package.json
@@ -44,8 +44,7 @@
     "postclean": "rimraf dist && rimraf src/generated && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "generate-lib": "npx nx run scope-manager:generate-lib",
-    "lint": "npx nx lint",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "lint": "npx nx lint"
   },
   "nx": {
     "targets": {

diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
@@ -48,8 +48,7 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "nx lint",
-    "test": "jest --coverage --passWithNoTests",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage --passWithNoTests"
   },
   "peerDependencies": {
     "eslint": "^8.56.0"

diff --git a/packages/typescript-estree/package.json b/packages/typescript-estree/package.json
@@ -50,8 +50,7 @@
     "postclean": "rimraf dist && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage --runInBand --verbose",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage --runInBand --verbose"
   },
   "dependencies": {
     "@typescript-eslint/types": "7.8.0",

diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -63,8 +63,7 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage"
   },
   "dependencies": {
     "@eslint-community/eslint-utils": "^4.4.0",

diff --git a/packages/visitor-keys/package.json b/packages/visitor-keys/package.json
@@ -43,8 +43,7 @@
     "postclean": "rimraf dist && rimraf _ts3.4 && rimraf _ts4.3 && rimraf coverage",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
     "lint": "npx nx lint",
-    "test": "jest --coverage",
-    "typecheck": "tsc -p tsconfig.json --noEmit"
+    "test": "jest --coverage"
   },
   "dependencies": {
     "@typescript-eslint/types": "7.8.0",

diff --git a/packages/website-eslint/package.json b/packages/website-eslint/package.json
@@ -19,8 +19,7 @@
   "scripts": {
     "build": "yarn tsx ./build.ts",
     "format": "prettier --write \"./**/*.{ts,mts,cts,tsx,js,mjs,cjs,jsx,json,md,css}\" --ignore-path ../../.prettierignore",
-    "lint": "npx nx lint",
-    "typecheck": "tsc --noEmit"
+    "lint": "npx nx lint"
   },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "7.8.0",

diff --git a/packages/website/package.json b/packages/website/package.json
@@ -12,8 +12,7 @@
     "lint": "npx nx lint",
     "serve": "docusaurus serve",
     "start": "npx nx start",
-    "swizzle": "docusaurus swizzle",
-    "typecheck": "tsc -b ./tsconfig.json"
+    "swizzle": "docusaurus swizzle"
   },
   "dependencies": {
     "@babel/runtime": "^7.24.4",