change: [unified-signatures] check every b.params[i]

typescript-eslint · Apr 22, 2023 · 47286f7 · 47286f7
1 parent 0e31dbe
commit 47286f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts
@@ -213,11 +213,9 @@ export default util.createRule<Options, MessageIds>({
         b.typeParameters !== undefined ? b.typeParameters.params : undefined;
 
       if (ignoreDifferentlyNamedParameters) {
-        if (b.params.length === 0) {
-          return false;
-        }
         for (let i = 0; i < a.params.length; i += 1) {
           if (
+            b.params[i] &&
             a.params[i].type === b.params[i].type &&
             getStaticParameterName(a.params[i]) !==
               getStaticParameterName(b.params[i])

diff --git a/packages/eslint-plugin/tests/rules/unified-signatures.test.ts b/packages/eslint-plugin/tests/rules/unified-signatures.test.ts
@@ -184,6 +184,13 @@ function f(): string;
     },
     {
       code: `
+function f(v: boolean, u: boolean): number;
+function f(v: boolean): string;
+      `,
+      options: [{ ignoreDifferentlyNamedParameters: true }],
+    },
+    {
+      code: `
 function f(v: number, u?: string): void {}
 function f(v: number): void;
 function f(): string;