fix(eslint-plugin): [no-useless-template-literals] incorrect bigint a…

…utofix result
typescript-eslint · Jan 21, 2024 · 5bbfc11 · 5bbfc11
1 parent 920f909
commit 5bbfc11
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 10 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-useless-template-literals.ts b/packages/eslint-plugin/src/rules/no-useless-template-literals.ts
@@ -6,6 +6,7 @@ import {
   createRule,
   getConstrainedTypeAtLocation,
   getParserServices,
+  getStaticStringValue,
   isTypeFlagSet,
   isUndefinedIdentifier,
 } from '../util';
@@ -118,16 +119,10 @@ export default createRule<[], MessageId>({
                 ]),
               ];
 
-              // Remove quotes for string literals (i.e. `'a'` will become `a`).
-              const isStringLiteral =
-                isUnderlyingTypeString(expression) &&
-                expression.type === AST_NODE_TYPES.Literal;
+              const stringValue = getStaticStringValue(expression);
 
-              if (isStringLiteral) {
-                const escapedValue = expression.value.replace(
-                  /([`$\\])/g,
-                  '\\$1',
-                );
+              if (stringValue != null) {
+                const escapedValue = stringValue.replace(/([`$\\])/g, '\\$1');
 
                 fixes.push(fixer.replaceText(expression, escapedValue));
               }

diff --git a/packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts b/packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts
@@ -17,7 +17,6 @@ ruleTester.run('no-useless-template-literals', rule, {
   valid: [
     "const string = 'a';",
     'const string = `a`;',
-
     `
       declare const string: 'a';
       \`\${string}b\`;
@@ -147,6 +146,30 @@ ruleTester.run('no-useless-template-literals', rule, {
         },
       ],
     },
+    {
+      code: '`${1n}`;',
+      output: '`1`;',
+      errors: [
+        {
+          messageId: 'noUselessTemplateLiteral',
+          line: 1,
+          column: 4,
+          endColumn: 6,
+        },
+      ],
+    },
+    {
+      code: '`${/a/}`;',
+      output: '`/a/`;',
+      errors: [
+        {
+          messageId: 'noUselessTemplateLiteral',
+          line: 1,
+          column: 4,
+          endColumn: 7,
+        },
+      ],
+    },
 
     {
       code: noFormat`\`\${    1    }\`;`,