refactor(eslint-plugin): remove unnecessary if-statements in `expli…

…citReturnTypeUtils` (#3839)
typescript-eslint · Sep 22, 2021 · 9b13a86 · 9b13a86
1 parent 13b7de5
commit 9b13a86
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/packages/eslint-plugin/src/util/explicitReturnTypeUtils.ts b/packages/eslint-plugin/src/util/explicitReturnTypeUtils.ts
@@ -225,15 +225,11 @@ function isValidFunctionExpressionReturnType(
   }
 
   // https://github.com/typescript-eslint/typescript-eslint/issues/653
-  if (
-    options.allowDirectConstAssertionInArrowFunctions &&
+  return (
+    options.allowDirectConstAssertionInArrowFunctions === true &&
     node.type === AST_NODE_TYPES.ArrowFunctionExpression &&
     returnsConstAssertionDirectly(node)
-  ) {
-    return true;
-  }
-
-  return false;
+  );
 }
 
 /**
@@ -250,11 +246,11 @@ function isValidFunctionReturnType(
     return true;
   }
 
-  if (node.returnType || isConstructor(node.parent) || isSetter(node.parent)) {
-    return true;
-  }
-
-  return false;
+  return (
+    node.returnType != null ||
+    isConstructor(node.parent) ||
+    isSetter(node.parent)
+  );
 }
 
 /**