feat(eslint-plugin): [no-unnecessary-type-arguments] handle tagged te…

…mplates (#8708)
typescript-eslint · Mar 25, 2024 · a08554a · a08554a
1 parent 2018f91
commit a08554a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts
@@ -132,7 +132,11 @@ function getTypeParametersFromNode(
     return getTypeParametersFromType(node.typeName, checker);
   }
 
-  if (ts.isCallExpression(node) || ts.isNewExpression(node)) {
+  if (
+    ts.isCallExpression(node) ||
+    ts.isNewExpression(node) ||
+    ts.isTaggedTemplateExpression(node)
+  ) {
     return getTypeParametersFromCall(node, checker);
   }
 
@@ -165,7 +169,7 @@ function getTypeParametersFromType(
 }
 
 function getTypeParametersFromCall(
-  node: ts.CallExpression | ts.NewExpression,
+  node: ts.CallExpression | ts.NewExpression | ts.TaggedTemplateExpression,
   checker: ts.TypeChecker,
 ): readonly ts.TypeParameterDeclaration[] | undefined {
   const sig = checker.getResolvedSignature(node);

diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-type-arguments.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-type-arguments.test.ts
@@ -68,6 +68,14 @@ declare const g: unknown;
 g<string, string>();
     `,
     `
+declare const f: unknown;
+f<string>\`\`;
+    `,
+    `
+function f<T = number>(template: TemplateStringsArray) {}
+f<string>\`\`;
+    `,
+    `
 class C<T = number> {}
 new C<string>();
     `,
@@ -183,6 +191,22 @@ g<string>();
     },
     {
       code: `
+function f<T = number>(templates: TemplateStringsArray, arg: T) {}
+f<number>\`\${1}\`;
+      `,
+      errors: [
+        {
+          column: 3,
+          messageId: 'unnecessaryTypeParameter',
+        },
+      ],
+      output: `
+function f<T = number>(templates: TemplateStringsArray, arg: T) {}
+f\`\${1}\`;
+      `,
+    },
+    {
+      code: `
 class C<T = number> {}
 function h(c: C<number>) {}
       `,