Skip to content

Commit

Permalink
chore: bump Node to ESLint 8.0 ranges (#3767)
Browse files Browse the repository at this point in the history
  • Loading branch information
Josh Goldberg authored and bradzacher committed Oct 11, 2021
1 parent 0acfafc commit b63013a
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 14 deletions.
15 changes: 11 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
NX_BRANCH: ${{ github.event.number }}
NX_RUN_GROUP: ${{ github.run_id }}
# Added the - at the end to function as a separator to improve readability in the PR comment from the Nx cloud app
NX_CLOUD_ENV_NAME: "Node 12.x -"
NX_CLOUD_ENV_NAME: 'Node 12.x -'

jobs:
typecheck:
Expand Down Expand Up @@ -224,10 +224,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 14.x]
node-version: [12.x, 14.x, 16.x]
env:
# Added the - at the end to function as a separator to improve readability in the PR comment from the Nx cloud app
NX_CLOUD_ENV_NAME: "Node ${{ matrix.node-version }} -"
NX_CLOUD_ENV_NAME: 'Node ${{ matrix.node-version }} -'
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -296,7 +296,14 @@ jobs:
publish_canary_version:
name: Publish the latest code as a canary version
runs-on: ubuntu-latest
needs: [typecheck, test_on_primary_node_version, unit_tests_on_other_node_versions, linting_and_style, integration_tests]
needs:
[
typecheck,
test_on_primary_node_version,
unit_tests_on_other_node_versions,
linting_and_style,
integration_tests,
]
if: github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/master'
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}
},
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"devDependencies": {
"@babel/code-frame": "^7.12.13",
Expand Down
2 changes: 1 addition & 1 deletion packages/ast-spec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"estree"
],
"engines": {
"node": "^8.10.0 || ^10.13.0 || >=11.10.1"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-tslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"tslint"
],
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"typescript"
],
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/experimental-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"estree"
],
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"LICENSE"
],
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"estree"
],
"engines": {
"node": "^8.10.0 || ^10.13.0 || >=11.10.1"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"estree"
],
"engines": {
"node": "^8.10.0 || ^10.13.0 || >=11.10.1"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-estree/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"LICENSE"
],
"engines": {
"node": "^10.12.0 || >=12.0.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/visitor-keys/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"estree"
],
"engines": {
"node": "^8.10.0 || ^10.13.0 || >=11.10.1"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"files": [
"dist",
Expand Down

1 comment on commit b63013a

@lcw0622

This comment was marked as spam.

Please sign in to comment.