Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggestion types, suggestions for no-explicit-any #1250

Merged
merged 3 commits into from
Nov 24, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1249

I wanted to add an example usage at the same time.
no-explicit-any seemed like a good candidate because it's not possible to explicitly fix to this.
Suggestions are the perfect use case for it!

@bradzacher bradzacher added the enhancement New feature or request label Nov 23, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #1250 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   94.28%   94.29%   +<.01%     
==========================================
  Files         126      126              
  Lines        5393     5395       +2     
  Branches     1517     1517              
==========================================
+ Hits         5085     5087       +2     
  Misses        176      176              
  Partials      132      132
Impacted Files Coverage Δ
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 0% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 100% <100%> (ø) ⬆️

@platinumazure
Copy link
Contributor

This is really awesome! I'm excited to see real-world usage of the suggestions feature in a major plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new suggestions API
2 participants