Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): add ban-ts-ignore rule #276

Merged
merged 3 commits into from
Feb 14, 2019
Merged

feat(eslint-plugin): add ban-ts-ignore rule #276

merged 3 commits into from
Feb 14, 2019

Conversation

ldrick
Copy link
Contributor

@ldrick ldrick commented Feb 14, 2019

This PR shall add the rule ban-ts-ignore like tslint supports.

@codecov
Copy link

codecov bot commented Feb 14, 2019 •
edited
Loading

Codecov Report

Merging #276 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   94.84%   94.86%   +0.02%     
==========================================
  Files          66       67       +1     
  Lines        2796     2807      +11     
  Branches      724      726       +2     
==========================================
+ Hits         2652     2663      +11     
  Misses         55       55              
  Partials       89       89
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-ignore.ts 100% <100%> (ø)

armano2
armano2 reviewed Feb 14, 2019
View reviewed changes
Copy link
Member

@armano2 armano2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just add some missing tests

packages/eslint-plugin/tests/rules/ban-ts-ignore.test.ts Show resolved Hide resolved
packages/eslint-plugin/tests/rules/ban-ts-ignore.test.ts Show resolved Hide resolved
@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Feb 14, 2019
@bradzacher bradzacher merged commit 859ab29 into typescript-eslint:master Feb 14, 2019
@ldrick ldrick deleted the ban-ts-ignore branch April 30, 2019 07:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Luckeu pushed a commit to Luckeu/typescript-eslint that referenced this pull request Jun 27, 2024
@antfu
fix: add @types/eslint as dependencies explicitly, fix typescript-e…
94097c9 
…slint#276
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldrick @armano2 @bradzacher