Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which rules require type information? #341

Closed
NilSet opened this issue Mar 8, 2019 · 2 comments · Fixed by #360
Closed

Which rules require type information? #341

NilSet opened this issue Mar 8, 2019 · 2 comments · Fixed by #360
Labels
documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@NilSet
Copy link
Contributor

NilSet commented Mar 8, 2019

Given the massive slowdown discovered in #243 , I would like to know which rules actually require type info. It would be nice to have that in the chart at https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md
@NilSet NilSet added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Mar 8, 2019
@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating and removed triage Waiting for maintainers to take a look labels Mar 9, 2019
@NilSet
Copy link
Contributor Author

NilSet commented Mar 17, 2019

Am I correct in thinking that rules which call getParserServices are the ones that depend on type info? If so I can make a PR adding the column to the readme.

NilSet pushed a commit to NilSet/typescript-eslint that referenced this issue Mar 17, 2019
docs(eslint-plugin): list rules requiring type info (typescript-eslin…
cbafaeb 
…t#341)

Add a 'require type information' column to the rule summary table.
Also align the recommended rules with the actual config.
@bradzacher
Copy link
Member

You are correct. Rules that call getParserServices will throw if they do not have a project defined in the config.

@NilSet NilSet mentioned this issue Mar 20, 2019
Merged
bradzacher pushed a commit that referenced this issue Mar 27, 2019
@NilSet @bradzacher
docs(eslint-plugin): list rules requiring type info (#360)
6f5c0fa 
Fixes #341
@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(eslint-plugin): list rules requiring type info (#341) NilSet/typescript-eslint
2 participants
@NilSet @bradzacher