-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename experimental-utils
to utils
and make experimental-utils
an alias to the new package
#4172
feat: rename experimental-utils
to utils
and make experimental-utils
an alias to the new package
#4172
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: 2b0b349 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61df5d6baaf9930008fa522a 😎 Browse the preview: https://deploy-preview-4172--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #4172 +/- ##
==========================================
- Coverage 94.26% 91.40% -2.87%
==========================================
Files 169 202 +33
Lines 9440 8713 -727
Branches 2940 2697 -243
==========================================
- Hits 8899 7964 -935
- Misses 321 548 +227
+ Partials 220 201 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing updates in references in:
packages/parser/tsconfig.json
packages/parser/tsconfig.build.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all the hard work so far!
Please could you merge in the latest main and fix up the conflicts so we can run the CI workflows, it seems they aren't running on your commits right now and I imagine it's because it predates the master -> main rename?
5e6be09
to
a9eb0b9
Compare
Oh hey, CI passed! That's nice. I ended up rebasing because there were a lot of merge conflicts and I didn't want to sort through them manually. It was much easier to re-apply the same find-and-replace strings and manual touchups from before. |
the package.jsons are conflicting cos of the release bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you added cypress artefacts to this PR - I think those are for your other PR?
Heh, yes, will remove - been off and on the computer this last week.... |
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
experimental-utils
to utils
and make experimental-utils
an alias to the new package
Bravo 👏 |
PR Checklist
Overview