Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule proposal: no-floating-promises #464

Closed
w0rp opened this issue Apr 24, 2019 · 0 comments · Fixed by #495
Closed

Rule proposal: no-floating-promises #464

w0rp opened this issue Apr 24, 2019 · 0 comments · Fixed by #495
Labels
enhancement: new plugin rule New rule request for eslint-plugin package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@w0rp
Copy link

w0rp commented Apr 24, 2019

See #339 for existing discussion on this.

The ESLint plugin should implement a new version of the no-floating-promises rule from TSLint. This rule requires type information, and no equivalent exists yet in other tools. eslint-plugin-promise offers some of the functionality, but because the plugin does not have access to type information, it is not nearly as powerful. Implementing this rule will help organisations with replacing TSLint with typescript-eslint tools instead.
@w0rp w0rp added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Apr 24, 2019
@bradzacher bradzacher added enhancement: new plugin rule New rule request for eslint-plugin and removed triage Waiting for maintainers to take a look labels Apr 24, 2019
princjef added a commit to princjef/typescript-eslint that referenced this issue May 6, 2019
@princjef
feat(eslint-plugin): added new rule no-floating-promises
45c69b0 
Adds the equivalent of TSLint's `no-floating-promises` rule. Fixes typescript-eslint#464
princjef added a commit to princjef/typescript-eslint that referenced this issue May 6, 2019
@princjef
feat(eslint-plugin): added new rule no-floating-promises
d4b0bc3 
Adds the equivalent of TSLint's `no-floating-promises` rule. Fixes typescript-eslint#464
princjef added a commit to princjef/typescript-eslint that referenced this issue May 6, 2019
@princjef
feat(eslint-plugin): add new rule no-floating-promises
f897a68 
Adds the equivalent of TSLint's `no-floating-promises` rule. Fixes typescript-eslint#464
@princjef princjef mentioned this issue May 6, 2019
Merged
princjef added a commit to princjef/typescript-eslint that referenced this issue May 7, 2019
@princjef
feat(eslint-plugin): add new rule no-floating-promises
6bb84bd 
Adds the equivalent of TSLint's `no-floating-promises` rule. Fixes typescript-eslint#464
@bajtos bajtos mentioned this issue May 24, 2019
Merged
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: new plugin rule New rule request for eslint-plugin package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): add new rule no-floating-promises princjef/typescript-eslint
2 participants
@w0rp @bradzacher